From 330137e7e4ec72bd9367626af1513b3fe51d1801 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Wed, 7 Jun 2023 11:40:43 +0200 Subject: [PATCH] FIX: Non-Interfering Backdrop Clicks (#21916) Previously, there was an issue where closing the message actions menu on mobile would unintentionally trigger a click event on an element below it, such as a thread indicator or a reaction. With the recent fix, this problem has been resolved. Now, when you close the menu, it will no longer interfere with or activate any elements positioned underneath it. --- .../discourse/components/chat-message-actions-mobile.hbs | 2 +- .../discourse/components/chat-message-actions-mobile.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.hbs b/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.hbs index b232493a669..8b15d1e73f3 100644 --- a/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.hbs +++ b/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.hbs @@ -9,7 +9,7 @@
diff --git a/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.js b/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.js index 8432c5a4bc0..064954cd44b 100644 --- a/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.js +++ b/plugins/chat/assets/javascripts/discourse/components/chat-message-actions-mobile.js @@ -48,7 +48,7 @@ export default class ChatMessageActionsMobile extends Component { @action collapseMenu(event) { - event.stopPropagation(); + event.preventDefault(); this.#onCloseMenu(); }