IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: Ensure tag-info does not persist onto non-tag routes (#24462)

Browse Source
This commit is contained in:
David Taylor 2023-11-20 15:43:35 +00:00 committed by GitHub
parent 1a43010603
commit 3408db94f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/templates/discovery/list.hbs
View File

@ -26,7 +26,7 @@
@parentCategory={{this.model.subcategoryList.parentCategory}} @parentCategory={{this.model.subcategoryList.parentCategory}}
/> />
{{/if}} {{/if}}
{{#if this.showTagInfo}} {{#if (and this.showTagInfo this.model.tag)}}
<TagInfo @tag={{this.model.tag}} @list={{this.model.list}} /> <TagInfo @tag={{this.model.tag}} @list={{this.model.list}} />
{{/if}} {{/if}}
</:header> </:header>

11
app/assets/javascripts/discourse/tests/acceptance/tags-test.js
View File

@ -475,6 +475,17 @@ acceptance("Tag info", function (needs) {
); );
}); });
test("tag info hides when tag filter removed", async function (assert) {
await visit("/tag/happy-monkey");
await click("#show-tag-info");
assert.dom(".tag-info .tag-name").exists();
await visit("/latest");
assert.dom(".tag-info").doesNotExist("tag info is not shown on homepage");
});
test("can filter tags page by category", async function (assert) { test("can filter tags page by category", async function (assert) {
await visit("/tag/planters"); await visit("/tag/planters");