A11Y: UI emoji are decorative, use alt="" (#23690)

This commit is contained in:
Kris 2023-09-28 13:30:19 -04:00 committed by GitHub
parent a5df906af3
commit 34cc87db40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 6 additions and 26 deletions

View File

@ -1,10 +1,6 @@
<section class="current-badges"> <section class="current-badges">
<div class="badge-intro admin-intro"> <div class="badge-intro admin-intro">
<img <img src={{this.badgeIntroEmoji}} class="badge-intro-emoji" alt="" />
src={{this.badgeIntroEmoji}}
class="badge-intro-emoji"
alt={{i18n "admin.badges.badge_intro.emoji"}}
/>
<div class="content-wrapper"> <div class="content-wrapper">
<h1>{{i18n "admin.badges.badge_intro.title"}}</h1> <h1>{{i18n "admin.badges.badge_intro.title"}}</h1>
<div class="external-resources"> <div class="external-resources">

View File

@ -1,8 +1,5 @@
<div class="themes-intro admin-intro"> <div class="themes-intro admin-intro">
<img <img src={{this.womanArtistEmojiURL}} alt="" />
src={{this.womanArtistEmojiURL}}
alt={{i18n "admin.customize.theme.themes_intro_emoji"}}
/>
<div class="content-wrapper"> <div class="content-wrapper">
<h1>{{i18n "admin.customize.theme.themes_intro"}}</h1> <h1>{{i18n "admin.customize.theme.themes_intro"}}</h1>
<div class="create-actions"> <div class="create-actions">

View File

@ -7,7 +7,7 @@
<div class="ac-page"> <div class="ac-page">
<div class="two-col"> <div class="two-col">
<div class="col-image"> <div class="col-image">
<img src={{this.envelopeImageUrl}} alt={{i18n "invites.emoji"}} /> <img src={{this.envelopeImageUrl}} alt="" />
</div> </div>
<div class="col-form"> <div class="col-form">
<div class="success-info"> <div class="success-info">

View File

@ -1,11 +1,7 @@
<div class="container email-login clearfix"> <div class="container email-login clearfix">
<div class="content-wrapper"> <div class="content-wrapper">
<div class="image-wrapper"> <div class="image-wrapper">
<img <img src={{this.lockImageUrl}} class="password-reset-img" alt="" />
src={{this.lockImageUrl}}
class="password-reset-img"
alt={{i18n "email_login.emoji"}}
/>
</div> </div>
<form> <form>

View File

@ -13,7 +13,7 @@
<div class={{if this.successMessage "invite-success" "invite-form"}}> <div class={{if this.successMessage "invite-success" "invite-form"}}>
<div class="two-col"> <div class="two-col">
<div class="col-image"> <div class="col-image">
<img src={{this.inviteImageUrl}} alt={{i18n "invites.emoji"}} /> <img src={{this.inviteImageUrl}} alt="" />
</div> </div>
<div class="col-form"> <div class="col-form">

View File

@ -1,10 +1,6 @@
<div class="container password-reset clearfix"> <div class="container password-reset clearfix">
<div class="pull-left col-image"> <div class="pull-left col-image">
<img <img src={{this.lockImageUrl}} class="password-reset-img" alt="" />
src={{this.lockImageUrl}}
class="password-reset-img"
alt={{i18n "user.change_password.emoji"}}
/>
</div> </div>
<div class="pull-left col-form"> <div class="pull-left col-form">

View File

@ -1420,7 +1420,6 @@ en:
success: "(email sent)" success: "(email sent)"
in_progress: "(sending email)" in_progress: "(sending email)"
error: "(error)" error: "(error)"
emoji: "lock emoji"
action: "Send Password Reset Email" action: "Send Password Reset Email"
set_password: "Set Password" set_password: "Set Password"
choose_new: "Choose a new password" choose_new: "Choose a new password"
@ -2136,7 +2135,6 @@ en:
link_label: "Email me a login link" link_label: "Email me a login link"
button_label: "with email" button_label: "with email"
login_link: "Skip the password; email me a login link" login_link: "Skip the password; email me a login link"
emoji: "lock emoji"
complete_username: "If an account matches the username <b>%{username}</b>, you should receive an email with a login link shortly." complete_username: "If an account matches the username <b>%{username}</b>, you should receive an email with a login link shortly."
complete_email: "If an account matches <b>%{email}</b>, you should receive an email with a login link shortly." complete_email: "If an account matches <b>%{email}</b>, you should receive an email with a login link shortly."
complete_username_found: "We found an account that matches the username <b>%{username}</b>, you should receive an email with a login link shortly." complete_username_found: "We found an account that matches the username <b>%{username}</b>, you should receive an email with a login link shortly."
@ -2230,7 +2228,6 @@ en:
security_key: "Use a security key instead" security_key: "Use a security key instead"
invites: invites:
accept_title: "Invitation" accept_title: "Invitation"
emoji: "envelope emoji"
welcome_to: "Welcome to %{site_name}!" welcome_to: "Welcome to %{site_name}!"
invited_by: "You were invited by:" invited_by: "You were invited by:"
social_login_available: "You'll also be able to sign in with any social login using that email." social_login_available: "You'll also be able to sign in with any social login using that email."
@ -5129,7 +5126,6 @@ en:
theme_name: "Theme name" theme_name: "Theme name"
component_name: "Component name" component_name: "Component name"
themes_intro: "Select an existing theme or install a new one to get started" themes_intro: "Select an existing theme or install a new one to get started"
themes_intro_emoji: "woman artist emoji"
beginners_guide_title: "Beginners guide to using Discourse Themes" beginners_guide_title: "Beginners guide to using Discourse Themes"
developers_guide_title: "Developers guide to Discourse Themes" developers_guide_title: "Developers guide to Discourse Themes"
browse_themes: "Browse community themes" browse_themes: "Browse community themes"
@ -6295,7 +6291,6 @@ en:
with_time: <span class="username">%{username}</span> at <span class="time">%{time}</span> with_time: <span class="username">%{username}</span> at <span class="time">%{time}</span>
badge_intro: badge_intro:
title: "Select an existing badge or create a new one to get started" title: "Select an existing badge or create a new one to get started"
emoji: "woman student emoji"
what_are_badges_title: "What are badges?" what_are_badges_title: "What are badges?"
badge_query_examples_title: "Badge query examples" badge_query_examples_title: "Badge query examples"
mass_award: mass_award: