IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: unparallel flags system spec (#27903)

Browse Source 
DEV: unparallel flags system spec

Because of the global flag cache, those specs should not run in parallel. We need to execute them sequentially.
This commit is contained in:
Krzysztof Kotlarek 2024-07-15 09:36:54 +10:00 committed by GitHub
parent c0bcd979e3
commit 367040024b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
spec/system/admin_flags_spec.rb
View File

@ -12,7 +12,8 @@ describe "Admin Flags Page", type: :system do
before { sign_in(admin) } before { sign_in(admin) }
it "allows admin to disable flags" do it "allows admin to disable, change order, create, update and delete flags" do
# disable
topic_page.visit_topic(post.topic) topic_page.visit_topic(post.topic)
topic_page.open_flag_topic_modal topic_page.open_flag_topic_modal
expect(all(".flag-action-type-details strong").map(&:text)).to eq( expect(all(".flag-action-type-details strong").map(&:text)).to eq(
@ -30,9 +31,8 @@ describe "Admin Flags Page", type: :system do
) )
Flag.system.where(name: "spam").update!(enabled: true) Flag.system.where(name: "spam").update!(enabled: true)
end
it "allows admin to change order of flags" do # change order
topic_page.visit_topic(post.topic) topic_page.visit_topic(post.topic)
topic_page.open_flag_topic_modal topic_page.open_flag_topic_modal
expect(all(".flag-action-type-details strong").map(&:text)).to eq( expect(all(".flag-action-type-details strong").map(&:text)).to eq(
@ -58,9 +58,8 @@ describe "Admin Flags Page", type: :system do
expect(all(".flag-action-type-details strong").map(&:text)).to eq( expect(all(".flag-action-type-details strong").map(&:text)).to eq(
["It's Inappropriate", "It's Spam", "It's Illegal", "Something Else"], ["It's Inappropriate", "It's Spam", "It's Illegal", "Something Else"],
) )
end
it "allows admin to create, edit and delete flags" do # create
topic_page.visit_topic(post.topic) topic_page.visit_topic(post.topic)
topic_page.open_flag_topic_modal topic_page.open_flag_topic_modal
expect(all(".flag-action-type-details strong").map(&:text)).to eq( expect(all(".flag-action-type-details strong").map(&:text)).to eq(
@ -97,6 +96,7 @@ describe "Admin Flags Page", type: :system do
["It's Inappropriate", "It's Spam", "It's Illegal", "Something Else", "Vulgar"], ["It's Inappropriate", "It's Spam", "It's Illegal", "Something Else", "Vulgar"],
) )
# update
visit "/admin/config/flags" visit "/admin/config/flags"
admin_flags_page.click_edit_flag("vulgar") admin_flags_page.click_edit_flag("vulgar")
@ -104,12 +104,25 @@ describe "Admin Flags Page", type: :system do
admin_flag_form_page.fill_in_name("Tasteless") admin_flag_form_page.fill_in_name("Tasteless")
admin_flag_form_page.click_save admin_flag_form_page.click_save
expect(all(".admin-flag-item__name").map(&:text)).to eq(
[
"Send @%{username} a message",
"Off-Topic",
"Inappropriate",
"Spam",
"Illegal",
"Something Else",
"Tasteless",
],
)
topic_page.visit_topic(post.topic) topic_page.visit_topic(post.topic)
topic_page.open_flag_topic_modal topic_page.open_flag_topic_modal
expect(all(".flag-action-type-details strong").map(&:text)).to eq( expect(all(".flag-action-type-details strong").map(&:text)).to eq(
["It's Inappropriate", "It's Spam", "It's Illegal", "Something Else", "Tasteless"], ["It's Inappropriate", "It's Spam", "It's Illegal", "Something Else", "Tasteless"],
) )
# delete
visit "/admin/config/flags" visit "/admin/config/flags"
admin_flags_page.click_delete_flag("tasteless") admin_flags_page.click_delete_flag("tasteless")
admin_flags_page.confirm_delete admin_flags_page.confirm_delete