mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FIX: Unlike own posts on ownership transfer (#10446)
* FIX: Unlike own posts on ownership transfer If a user has liked a post that has passed the `post_undo_action_window_mins` system setting window and you transfer ownership of that post to that user you will be the owner of a post that you have liked, but cannot unlike resulting in a weird UI behavior. This commit fixes this issue. The existing tests didn't check for the timeout window for unliking posts so I added that in. I couldn't find a good way to do this logic inside of the guardian class so rather than duplicating behavior of the `PostActionDestroyer` class inside of the `PostOwnerChanger` I decided to pass in a "bypass" variable that could be used to check if the calling class is the 'post_owner_changer' and bypass the guardian instead. I went this route because the guardian `can_delete_post_action` method has no way of distinguishing how to allow a user to be able to unlike their own posts after the timeout window but only on a post owner change. * use an options hash instead
This commit is contained in:
@@ -5,12 +5,12 @@ class PostActionDestroyer
|
||||
attr_accessor :post
|
||||
end
|
||||
|
||||
def initialize(destroyed_by, post, post_action_type_id)
|
||||
@destroyed_by, @post, @post_action_type_id = destroyed_by, post, post_action_type_id
|
||||
def initialize(destroyed_by, post, post_action_type_id, opts = {})
|
||||
@destroyed_by, @post, @post_action_type_id, @opts = destroyed_by, post, post_action_type_id, opts
|
||||
end
|
||||
|
||||
def self.destroy(destroyed_by, post, action_key)
|
||||
new(destroyed_by, post, PostActionType.types[action_key]).perform
|
||||
def self.destroy(destroyed_by, post, action_key, opts = {})
|
||||
new(destroyed_by, post, PostActionType.types[action_key], opts).perform
|
||||
end
|
||||
|
||||
def perform
|
||||
@@ -34,7 +34,7 @@ class PostActionDestroyer
|
||||
return result
|
||||
end
|
||||
|
||||
unless guardian.can_delete?(post_action)
|
||||
unless @opts[:skip_delete_check] == true || guardian.can_delete?(post_action)
|
||||
result.forbidden = true
|
||||
result.add_error(I18n.t("invalid_access"))
|
||||
return result
|
||||
|
||||
Reference in New Issue
Block a user