mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FIX: Unlike own posts on ownership transfer (#10446)
* FIX: Unlike own posts on ownership transfer If a user has liked a post that has passed the `post_undo_action_window_mins` system setting window and you transfer ownership of that post to that user you will be the owner of a post that you have liked, but cannot unlike resulting in a weird UI behavior. This commit fixes this issue. The existing tests didn't check for the timeout window for unliking posts so I added that in. I couldn't find a good way to do this logic inside of the guardian class so rather than duplicating behavior of the `PostActionDestroyer` class inside of the `PostOwnerChanger` I decided to pass in a "bypass" variable that could be used to check if the calling class is the 'post_owner_changer' and bypass the guardian instead. I went this route because the guardian `can_delete_post_action` method has no way of distinguishing how to allow a user to be able to unlike their own posts after the timeout window but only on a post owner change. * use an options hash instead
This commit is contained in:
@@ -24,12 +24,15 @@ describe PostOwnerChanger do
|
||||
|
||||
it "changes the user" do
|
||||
bumped_at = freeze_time topic.bumped_at
|
||||
now = Time.zone.now
|
||||
freeze_time(now - 1.day)
|
||||
|
||||
old_user = p1.user
|
||||
PostActionCreator.like(user_a, p1)
|
||||
p1.reload
|
||||
expect(p1.topic.like_count).to eq(1)
|
||||
|
||||
freeze_time(now)
|
||||
PostOwnerChanger.new(post_ids: [p1.id], topic_id: topic.id, new_owner: user_a, acting_user: editor).change_owner!
|
||||
p1.reload
|
||||
expect(p1.topic.like_count).to eq(0)
|
||||
|
||||
Reference in New Issue
Block a user