IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Rename delete_when_reminder_sent? bookmark method to avoid conflict with AR (#10333)

Browse Source 
I added delete_when_reminder_sent to ignored_columns because it no longer exists and added a shortcut method delete_when_reminder_sent? to the Bookmark model. However I have been seeing some weird errors like:

> Job exception: unknown attribute 'delete_when_reminder_sent' for Bookmark.

So I am very suspicious. I am just renaming the method to auto_delete_when_reminder_sent? to avoid any potential conflicts.

Also found include_bookmark_delete_on_owner_reply? in PostSerializer which is used for nothing; I must have forgotten to delete it before.
This commit is contained in:
Martin Brennan
2020-07-29 17:02:36 +10:00
committed by GitHub
parent 04a3b949a4
commit 36c11cb62b
3 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/bookmark_reminder_notification_handler.rb
View File

@@ -10,7 +10,7 @@ class BookmarkReminderNotificationHandler
create_notification(bookmark)
if bookmark.delete_when_reminder_sent?
if bookmark.auto_delete_when_reminder_sent?
BookmarkManager.new(bookmark.user).destroy(bookmark.id)
end