WIP - discourse/models/user not defined

app/assets/javascripts/discourse/controllers/preferences/username.js.es6

@@ -42,17 +42,15 @@ export default Controller.extend({
       if (isEmpty(this.newUsername)) return;
       if (this.unchanged) return;
 
-      User.checkUsername(
+      User.checkUsername(newUsername, undefined, this.get("model.id")).then(
-        newUsername,
+        result => {
-        undefined,
+          if (result.errors) {
-        this.get("model.id")
+            this.set("errorMessage", result.errors.join(" "));
-      ).then(result => {
+          } else if (result.available === false) {
-        if (result.errors) {
+            this.set("taken", true);
-          this.set("errorMessage", result.errors.join(" "));
+          }
-        } else if (result.available === false) {
-          this.set("taken", true);
         }
-      });
+      );
     }
   },
 

app/assets/javascripts/discourse/lib/click-track.js.es6

@@ -120,9 +120,7 @@ export default {
     }
 
     const isInternal = DiscourseURL.isInternal(href);
-    const openExternalInNewTab = User.currentProp(
+    const openExternalInNewTab = User.currentProp("external_links_in_new_tab");
-      "external_links_in_new_tab"
-    );
 
     if (!wantsNewWindow(e)) {
       if (!isInternal && openExternalInNewTab) {

app/assets/javascripts/discourse/lib/render-topic-featured-link.js.es6

@@ -10,9 +10,7 @@ export function addFeaturedLinkMetaDecorator(decorator) {
 
 export function extractLinkMeta(topic) {
   const href = topic.get("featured_link");
-  const target = User.currentProp("external_links_in_new_tab")
+  const target = User.currentProp("external_links_in_new_tab") ? "_blank" : "";
-    ? "_blank"
-    : "";
 
   if (!href) {
     return;

app/assets/javascripts/discourse/lib/utilities.js.es6

@@ -327,10 +327,7 @@ function staffExtensionsRegex() {
 }
 
 function isAuthorizedFile(fileName) {
-  if (
+  if (User.currentProp("staff") && staffExtensionsRegex().test(fileName)) {
-    User.currentProp("staff") &&
-    staffExtensionsRegex().test(fileName)
-  ) {
     return true;
   }
   return extensionsRegex().test(fileName);

app/assets/javascripts/discourse/mixins/username-validation.js.es6

@@ -77,44 +77,43 @@ export default Mixin.create({
 
   checkUsernameAvailability: discourseDebounce(function() {
     if (this.shouldCheckUsernameAvailability()) {
-      return User.checkUsername(
+      return User.checkUsername(this.accountUsername, this.accountEmail).then(
-        this.accountUsername,
+        result => {
-        this.accountEmail
+          this.set("isDeveloper", false);
-      ).then(result => {
+          if (result.available) {
-        this.set("isDeveloper", false);
+            if (result.is_developer) {
-        if (result.available) {
+              this.set("isDeveloper", true);
-          if (result.is_developer) {
+            }
-            this.set("isDeveloper", true);
-          }
-          return this.set(
-            "uniqueUsernameValidation",
-            EmberObject.create({
-              ok: true,
-              reason: I18n.t("user.username.available")
-            })
-          );
-        } else {
-          if (result.suggestion) {
             return this.set(
               "uniqueUsernameValidation",
               EmberObject.create({
-                failed: true,
+                ok: true,
-                reason: I18n.t("user.username.not_available", result)
+                reason: I18n.t("user.username.available")
               })
             );
           } else {
-            return this.set(
+            if (result.suggestion) {
-              "uniqueUsernameValidation",
+              return this.set(
-              EmberObject.create({
+                "uniqueUsernameValidation",
-                failed: true,
+                EmberObject.create({
-                reason: result.errors
+                  failed: true,
-                  ? result.errors.join(" ")
+                  reason: I18n.t("user.username.not_available", result)
-                  : I18n.t("user.username.not_available_no_suggestion")
+                })
-              })
+              );
-            );
+            } else {
+              return this.set(
+                "uniqueUsernameValidation",
+                EmberObject.create({
+                  failed: true,
+                  reason: result.errors
+                    ? result.errors.join(" ")
+                    : I18n.t("user.username.not_available_no_suggestion")
+                })
+              );
+            }
           }
         }
-      });
+      );
     }
   }, 500),
 

app/assets/javascripts/discourse/models/post-stream.js.es6

@@ -606,8 +606,7 @@ export default RestModel.extend({
         return this.findPostsByIds([postId])
           .then(posts => {
             const ignoredUsers =
-              User.current() &&
+              User.current() && User.current().get("ignored_users");
-              User.current().get("ignored_users");
             posts.forEach(p => {
               if (ignoredUsers && ignoredUsers.includes(p.username)) {
                 this.stream.removeObject(postId);

app/assets/javascripts/discourse/models/user.js.es6

@@ -27,7 +27,6 @@ import { Promise } from "rsvp";
 import { getProperties } from "@ember/object";
 import deprecated from "discourse-common/lib/deprecated";
 import Site from "discourse/models/site";
-import User from "discourse/models/user";
 
 export const SECOND_FACTOR_METHODS = {
   TOTP: 1,