From 38f80be810721e7bb57ee9216cd3ae22c72d1729 Mon Sep 17 00:00:00 2001
From: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Date: Thu, 11 Jul 2024 11:54:17 +0200
Subject: [PATCH] DEV: migrates reviewable-created-by-name to gjs (#27861)

---
 .../components/reviewable-created-by-name.gjs | 27 +++++++++++++++++++
 .../components/reviewable-created-by-name.hbs | 17 ------------
 .../components/reviewable-created-by-name.js  |  3 ---
 .../app/components/reviewable-item.hbs        |  5 +---
 .../app/components/reviewable-post-header.hbs |  2 +-
 .../discourse/app/templates/topic.hbs         |  5 +---
 6 files changed, 30 insertions(+), 29 deletions(-)
 create mode 100644 app/assets/javascripts/discourse/app/components/reviewable-created-by-name.gjs
 delete mode 100644 app/assets/javascripts/discourse/app/components/reviewable-created-by-name.hbs
 delete mode 100644 app/assets/javascripts/discourse/app/components/reviewable-created-by-name.js

diff --git a/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.gjs b/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.gjs
new file mode 100644
index 00000000000..acc7c0d0e8e
--- /dev/null
+++ b/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.gjs
@@ -0,0 +1,27 @@
+import { hash } from "@ember/helper";
+import PluginOutlet from "discourse/components/plugin-outlet";
+import UserLink from "discourse/components/user-link";
+import icon from "discourse-common/helpers/d-icon";
+import i18n from "discourse-common/helpers/i18n";
+
+const ReviewableCreatedByName = <template>
+  <div class="names">
+    <span class="username">
+      {{#if @user}}
+        <UserLink @user={{@user}}>{{@user.username}}</UserLink>
+        {{#if @user.silenced}}
+          {{icon "ban" title="user.silenced_tooltip"}}
+        {{/if}}
+      {{else}}
+        {{i18n "review.deleted_user"}}
+      {{/if}}
+    </span>
+    <PluginOutlet
+      @name="after-reviewable-post-user"
+      @connectorTagName="div"
+      @outletArgs={{hash user=@user}}
+    />
+  </div>
+</template>;
+
+export default ReviewableCreatedByName;
diff --git a/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.hbs b/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.hbs
deleted file mode 100644
index 26806b9c5ab..00000000000
--- a/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.hbs
+++ /dev/null
@@ -1,17 +0,0 @@
-<div class="names">
-  <span class="username">
-    {{#if this.user}}
-      <UserLink @user={{this.user}}>{{this.user.username}}</UserLink>
-      {{#if this.user.silenced}}
-        {{d-icon "ban" title="user.silenced_tooltip"}}
-      {{/if}}
-    {{else}}
-      {{i18n "review.deleted_user"}}
-    {{/if}}
-  </span>
-  <PluginOutlet
-    @name="after-reviewable-post-user"
-    @connectorTagName="div"
-    @outletArgs={{hash user=this.user}}
-  />
-</div>
\ No newline at end of file
diff --git a/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.js b/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.js
deleted file mode 100644
index 87d5ddb040f..00000000000
--- a/app/assets/javascripts/discourse/app/components/reviewable-created-by-name.js
+++ /dev/null
@@ -1,3 +0,0 @@
-import Component from "@ember/component";
-
-export default Component.extend({});
diff --git a/app/assets/javascripts/discourse/app/components/reviewable-item.hbs b/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
index 0d0f885035e..0bd1e763041 100644
--- a/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
+++ b/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
@@ -37,10 +37,7 @@
         {{#if this.reviewable.created_by}}
           <div class="editable-created-by">
             {{avatar this.reviewable.created_by imageSize="tiny"}}
-            <ReviewableCreatedByName
-              @user={{this.reviewable.created_by}}
-              @tagName=""
-            />
+            <ReviewableCreatedByName @user={{this.reviewable.created_by}} />
           </div>
         {{/if}}
 
diff --git a/app/assets/javascripts/discourse/app/components/reviewable-post-header.hbs b/app/assets/javascripts/discourse/app/components/reviewable-post-header.hbs
index d091ad87326..fb74062c881 100644
--- a/app/assets/javascripts/discourse/app/components/reviewable-post-header.hbs
+++ b/app/assets/javascripts/discourse/app/components/reviewable-post-header.hbs
@@ -1,5 +1,5 @@
 <div class="reviewable-post-header">
-  <ReviewableCreatedByName @user={{this.createdBy}} @tagName="" />
+  <ReviewableCreatedByName @user={{this.createdBy}} />
   {{#if this.reviewable.reply_to_post_number}}
     <a
       href={{concat
diff --git a/app/assets/javascripts/discourse/app/templates/topic.hbs b/app/assets/javascripts/discourse/app/templates/topic.hbs
index d27e4bdcc3c..f25dccb184a 100644
--- a/app/assets/javascripts/discourse/app/templates/topic.hbs
+++ b/app/assets/javascripts/discourse/app/templates/topic.hbs
@@ -404,10 +404,7 @@
                           @tagName=""
                         />
                         <div class="post-contents">
-                          <ReviewableCreatedByName
-                            @user={{this.currentUser}}
-                            @tagName=""
-                          />
+                          <ReviewableCreatedByName @user={{this.currentUser}} />
                           <div class="post-body"><CookText
                               @rawText={{pending.raw}}
                             /></div>