IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: stop mixing in application helper where not needed

Browse Source 
We were mixing in 20 or so methods into a controller just to use a single
one.

The helper itself is not the actual implementation anyway... MobileDetection
is responsible here.
This commit is contained in:
Sam Saffron
2019-10-09 13:06:18 +11:00
parent 602215a273
commit 3d5f71dac7
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/groups_controller.rb
View File

@@ -1,8 +1,6 @@
# frozen_string_literal: true # frozen_string_literal: true
class GroupsController < ApplicationController class GroupsController < ApplicationController
include ApplicationHelper
requires_login only: [ requires_login only: [
:set_notifications, :set_notifications,
:mentionable, :mentionable,
@@ -46,7 +44,7 @@ class GroupsController < ApplicationController
raise Discourse::InvalidAccess.new(:enable_group_directory) raise Discourse::InvalidAccess.new(:enable_group_directory)
end end
page_size = mobile_device? ? 15 : 36 page_size = MobileDetection.mobile_device?(request.user_agent) ? 15 : 36
page = params[:page]&.to_i || 0 page = params[:page]&.to_i || 0
order = %w{name user_count}.delete(params[:order]) order = %w{name user_count}.delete(params[:order])
dir = params[:asc] ? 'ASC' : 'DESC' dir = params[:asc] ? 'ASC' : 'DESC'