IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-16 10:14:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: ask for confirmation when deleting a post using shortcut (#16526)

Browse Source
This commit is contained in:
Andrei Prigorshnev 2022-04-26 01:50:54 +04:00 committed by GitHub
parent c1d9822003
commit 3e0cb8ea47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/discourse/app/controllers/topic.js
View File

@ -702,6 +702,19 @@ export default Controller.extend(bufferedProperty("model"), {
} }
}, },
deletePostWithConfirmation(post, opts) {
bootbox.confirm(
I18n.t("post.confirm_delete"),
I18n.t("no_value"),
I18n.t("yes_value"),
(confirmed) => {
if (confirmed) {
this.send("deletePost", post, opts);
}
}
);
},
permanentlyDeletePost(post) { permanentlyDeletePost(post) {
return bootbox.confirm( return bootbox.confirm(
I18n.t("post.controls.permanently_delete_confirmation"), I18n.t("post.controls.permanently_delete_confirmation"),

2
app/assets/javascripts/discourse/app/lib/keyboard-shortcuts.js
View File

@ -49,7 +49,7 @@ const DEFAULT_BINDINGS = {
"command+right": { handler: "webviewKeyboardForward", anonymous: true }, "command+right": { handler: "webviewKeyboardForward", anonymous: true },
"command+]": { handler: "webviewKeyboardForward", anonymous: true }, "command+]": { handler: "webviewKeyboardForward", anonymous: true },
"mod+p": { handler: "printTopic", anonymous: true }, "mod+p": { handler: "printTopic", anonymous: true },
d: { postAction: "deletePost" }, d: { postAction: "deletePostWithConfirmation" },
e: { handler: "editPost" }, e: { handler: "editPost" },
end: { handler: "goToLastPost", anonymous: true }, end: { handler: "goToLastPost", anonymous: true },
"command+down": { handler: "goToLastPost", anonymous: true }, "command+down": { handler: "goToLastPost", anonymous: true },

1
config/locales/client.en.yml
View File

@ -3053,6 +3053,7 @@ en:
deleted_by_author_simple: "(topic deleted by author)" deleted_by_author_simple: "(topic deleted by author)"
post: post:
confirm_delete: "Are you sure you want to delete this post?"
quote_reply: "Quote" quote_reply: "Quote"
quote_reply_shortcut: "Or press q" quote_reply_shortcut: "Or press q"
quote_edit: "Edit" quote_edit: "Edit"