IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Reorder custom ember-cli middleware to restore error page (#24383)

Browse Source 
Ember-cli has built-in error pages when there is a build error. Previously these were not being used in Discourse because our custom proxy middleware was too early in the stack. This commit reorders things  so that the "broccoli-watcher" middleware runs before our custom proxy. It also disables the `historySupportMiddleware`, which doesn't make sense in our 'always proxy' setup.
This commit is contained in:
David Taylor 2023-11-15 14:43:01 +00:00 committed by GitHub
parent 02cb262b2e
commit 3e45837d78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/bootstrap-json/package.json
View File

@ -9,9 +9,11 @@
], ],
"ember-addon": { "ember-addon": {
"before": [ "before": [
"serve-files-middleware", "broccoli-serve-files",
"history-support-middleware",
"proxy-server-middleware" "proxy-server-middleware"
],
"after": [
"broccoli-watcher"
] ]
}, },
"devDependencies": { "devDependencies": {

2
app/assets/javascripts/discourse/ember-cli-build.js
View File

@ -70,6 +70,8 @@ module.exports = function (defaults) {
backburner: backburner:
"node_modules/@discourse/backburner.js/dist/named-amd/backburner.js", "node_modules/@discourse/backburner.js/dist/named-amd/backburner.js",
}, },
historySupportMiddleware: false,
}); });
// TODO: remove me // TODO: remove me