From 3e8561daaf8f6a3a75943d1dec8e06e3254ca213 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Wed, 7 Oct 2020 12:14:49 -0400 Subject: [PATCH] REFACTOR: Some qunit `module` imports were missing These are tricky because `module.exports` is used by nodejs files as a global, which is OK. But we don't want to allow `module` in JS tests for qunit without importing it first. --- app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js | 1 + .../discourse/tests/unit/lib/click-track-edit-history-test.js | 2 +- .../discourse/tests/unit/lib/click-track-profile-page-test.js | 2 +- .../discourse/tests/unit/lib/highlight-search-test.js | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js b/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js index be1c7d0ca74..f386ba17459 100644 --- a/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js +++ b/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js @@ -36,6 +36,7 @@ import { setURLContainer } from "discourse/lib/url"; import { setDefaultOwner } from "discourse-common/lib/get-owner"; import bootbox from "bootbox"; import { moduleFor } from "ember-qunit"; +import { module } from "qunit"; export function currentUser() { return User.create(sessionFixtures["/session/current.json"].current_user); diff --git a/app/assets/javascripts/discourse/tests/unit/lib/click-track-edit-history-test.js b/app/assets/javascripts/discourse/tests/unit/lib/click-track-edit-history-test.js index 77610e16925..c3f78758bcc 100644 --- a/app/assets/javascripts/discourse/tests/unit/lib/click-track-edit-history-test.js +++ b/app/assets/javascripts/discourse/tests/unit/lib/click-track-edit-history-test.js @@ -1,4 +1,4 @@ -import { skip } from "qunit"; +import { module, skip } from "qunit"; import DiscourseURL from "discourse/lib/url"; import ClickTrack from "discourse/lib/click-track"; import { fixture, logIn } from "discourse/tests/helpers/qunit-helpers"; diff --git a/app/assets/javascripts/discourse/tests/unit/lib/click-track-profile-page-test.js b/app/assets/javascripts/discourse/tests/unit/lib/click-track-profile-page-test.js index fbcc27f707d..28fe7faba8c 100644 --- a/app/assets/javascripts/discourse/tests/unit/lib/click-track-profile-page-test.js +++ b/app/assets/javascripts/discourse/tests/unit/lib/click-track-profile-page-test.js @@ -1,4 +1,4 @@ -import { skip } from "qunit"; +import { module, skip } from "qunit"; import DiscourseURL from "discourse/lib/url"; import ClickTrack from "discourse/lib/click-track"; import { fixture, logIn } from "discourse/tests/helpers/qunit-helpers"; diff --git a/app/assets/javascripts/discourse/tests/unit/lib/highlight-search-test.js b/app/assets/javascripts/discourse/tests/unit/lib/highlight-search-test.js index be226af5378..34958ade38c 100644 --- a/app/assets/javascripts/discourse/tests/unit/lib/highlight-search-test.js +++ b/app/assets/javascripts/discourse/tests/unit/lib/highlight-search-test.js @@ -1,6 +1,6 @@ import highlightSearch, { CLASS_NAME } from "discourse/lib/highlight-search"; import { fixture } from "discourse/tests/helpers/qunit-helpers"; -import { test } from "qunit"; +import { module, test } from "qunit"; module("lib:highlight-search");