FIX: Change user digest email total unread notification calculation (#9648)

We now add together unread notifications (which are low-priority only) and unread high priority notifications (PMs and bookmark reminder notifications), and removed the separate "X unread high priority notifications" count in the user digest email.
This commit is contained in:
Martin Brennan
2020-05-06 14:23:13 +10:00
committed by GitHub
parent 4f26893d57
commit 4239ca1f8d

View File

@@ -213,12 +213,12 @@ class UserNotifications < ActionMailer::Base
value: new_topics_count,
href: "#{Discourse.base_url}/new" }]
value = user.unread_notifications
# totalling unread notifications (which are low-priority only) and unread
# PMs and bookmark reminder notifications, so the total is both unread low
# and high priority PMs
value = user.unread_notifications + user.unread_high_priority_notifications
@counts << { label_key: 'user_notifications.digest.unread_notifications', value: value, href: "#{Discourse.base_url}/my/notifications" } if value > 0
value = user.unread_high_priority_notifications
@counts << { label_key: 'user_notifications.digest.unread_high_priority', value: value, href: "#{Discourse.base_url}/my/notifications" } if value > 0
if @counts.size < 3
value = user.unread_notifications_of_type(Notification.types[:liked])
@counts << { label_key: 'user_notifications.digest.liked_received', value: value, href: "#{Discourse.base_url}/my/notifications" } if value > 0