IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Handle failed download when calculating image dominant color (#18342)

Browse Source 
This can happen when the upload size exceeds the maximum upload size, or there is a network issue during download
This commit is contained in:
David Taylor
2022-09-23 12:42:07 +01:00
committed by GitHub
parent 8964749989
commit 42947ec6f1
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/models/upload_spec.rb
View File

@@ -690,6 +690,15 @@ RSpec.describe Upload do
expect(invalid_image.dominant_color).to eq(nil)
end
it "correctly handles download failures" do
white_image.stubs(:local?).returns(true)
Discourse.store.stubs(:download).returns(nil)
expect(invalid_image.dominant_color).to eq(nil)
expect(invalid_image.dominant_color(calculate_if_missing: true)).to eq("")
expect(invalid_image.dominant_color).to eq("")
end
it "is validated for length" do
u = Fabricate(:upload)