IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix and unskip flaky specs (#22005)

Browse Source 
These specs were skipped in d6d5eae1. They sometimes failed, and only on CI, 
not in GitHub Actions. 

I wasn't able to reproduce failures locally, but I expect clicking the send button 
in chat composer should be more reliable than emulating pressing <kbd>Enter</kbd>.
This commit is contained in:
Andrei Prigorshnev 2023-06-08 18:28:42 +04:00 committed by GitHub
parent ccf18b5e44
commit 44eabde12f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
plugins/chat/test/javascripts/acceptance/user-status-on-mentions-test.js
View File

@ -5,14 +5,8 @@ import {
publishToMessageBus, publishToMessageBus,
query, query,
} from "discourse/tests/helpers/qunit-helpers"; } from "discourse/tests/helpers/qunit-helpers";
import { skip, test } from "qunit"; import { test } from "qunit";
import { import { click, triggerEvent, visit, waitFor } from "@ember/test-helpers";
click,
triggerEvent,
triggerKeyEvent,
visit,
waitFor,
} from "@ember/test-helpers";
import pretender, { OK } from "discourse/tests/helpers/create-pretender"; import pretender, { OK } from "discourse/tests/helpers/create-pretender";
acceptance("Chat | User status on mentions", function (needs) { acceptance("Chat | User status on mentions", function (needs) {
@ -100,7 +94,7 @@ acceptance("Chat | User status on mentions", function (needs) {
setupAutocompleteResponses([mentionedUser2, mentionedUser3]); setupAutocompleteResponses([mentionedUser2, mentionedUser3]);
}); });
skip("just posted messages | it shows status on mentions ", async function (assert) { test("just posted messages | it shows status on mentions ", async function (assert) {
await visit(`/chat/c/-/${channelId}`); await visit(`/chat/c/-/${channelId}`);
await typeWithAutocompleteAndSend(`mentioning @${mentionedUser2.username}`); await typeWithAutocompleteAndSend(`mentioning @${mentionedUser2.username}`);
assertStatusIsRendered( assertStatusIsRendered(
@ -110,7 +104,7 @@ acceptance("Chat | User status on mentions", function (needs) {
); );
}); });
skip("just posted messages | it updates status on mentions", async function (assert) { test("just posted messages | it updates status on mentions", async function (assert) {
await visit(`/chat/c/-/${channelId}`); await visit(`/chat/c/-/${channelId}`);
await typeWithAutocompleteAndSend(`mentioning @${mentionedUser2.username}`); await typeWithAutocompleteAndSend(`mentioning @${mentionedUser2.username}`);
@ -123,7 +117,7 @@ acceptance("Chat | User status on mentions", function (needs) {
assertStatusIsRendered(assert, selector, newStatus); assertStatusIsRendered(assert, selector, newStatus);
}); });
skip("just posted messages | it deletes status on mentions", async function (assert) { test("just posted messages | it deletes status on mentions", async function (assert) {
await visit(`/chat/c/-/${channelId}`); await visit(`/chat/c/-/${channelId}`);
await typeWithAutocompleteAndSend(`mentioning @${mentionedUser2.username}`); await typeWithAutocompleteAndSend(`mentioning @${mentionedUser2.username}`);
@ -137,7 +131,7 @@ acceptance("Chat | User status on mentions", function (needs) {
assert.dom(selector).doesNotExist("status is deleted"); assert.dom(selector).doesNotExist("status is deleted");
}); });
skip("edited messages | it shows status on mentions", async function (assert) { test("edited messages | it shows status on mentions", async function (assert) {
await visit(`/chat/c/-/${channelId}`); await visit(`/chat/c/-/${channelId}`);
await editMessage( await editMessage(
@ -152,7 +146,7 @@ acceptance("Chat | User status on mentions", function (needs) {
); );
}); });
skip("edited messages | it updates status on mentions", async function (assert) { test("edited messages | it updates status on mentions", async function (assert) {
await visit(`/chat/c/-/${channelId}`); await visit(`/chat/c/-/${channelId}`);
await editMessage( await editMessage(
".chat-message-content", ".chat-message-content",
@ -168,7 +162,7 @@ acceptance("Chat | User status on mentions", function (needs) {
assertStatusIsRendered(assert, selector, newStatus); assertStatusIsRendered(assert, selector, newStatus);
}); });
skip("edited messages | it deletes status on mentions", async function (assert) { test("edited messages | it deletes status on mentions", async function (assert) {
await visit(`/chat/c/-/${channelId}`); await visit(`/chat/c/-/${channelId}`);
await editMessage( await editMessage(
@ -318,7 +312,7 @@ acceptance("Chat | User status on mentions", function (needs) {
async function typeWithAutocompleteAndSend(text) { async function typeWithAutocompleteAndSend(text) {
await emulateAutocomplete(".chat-composer__input", text); await emulateAutocomplete(".chat-composer__input", text);
await click(".autocomplete.ac-user .selected"); await click(".autocomplete.ac-user .selected");
await triggerKeyEvent(".chat-composer__input", "keydown", "Enter"); await click(".chat-composer-button.-send");
} }
function setupAutocompleteResponses(results) { function setupAutocompleteResponses(results) {