From 459932f4e2a9d46f1d250ab03bba50c272c769ef Mon Sep 17 00:00:00 2001 From: Bianca Nenciu Date: Wed, 3 Jul 2019 17:48:13 +0300 Subject: [PATCH] FIX: Use title attribute for notification items. (#7840) --- .../discourse/widgets/custom-notification-item.js.es6 | 2 +- .../discourse/widgets/default-notification-item.js.es6 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/widgets/custom-notification-item.js.es6 b/app/assets/javascripts/discourse/widgets/custom-notification-item.js.es6 index 8ebff6692fe..ec567b51e5e 100644 --- a/app/assets/javascripts/discourse/widgets/custom-notification-item.js.es6 +++ b/app/assets/javascripts/discourse/widgets/custom-notification-item.js.es6 @@ -4,7 +4,7 @@ import { formatUsername } from "discourse/lib/utilities"; import { iconNode } from "discourse-common/lib/icon-library"; createWidgetFrom(DefaultNotificationItem, "custom-notification-item", { - title(notificationName, data) { + notificationTitle(notificationName, data) { return data.title ? I18n.t(data.title) : ""; }, diff --git a/app/assets/javascripts/discourse/widgets/default-notification-item.js.es6 b/app/assets/javascripts/discourse/widgets/default-notification-item.js.es6 index 610ac1f1285..afbdbb59bdf 100644 --- a/app/assets/javascripts/discourse/widgets/default-notification-item.js.es6 +++ b/app/assets/javascripts/discourse/widgets/default-notification-item.js.es6 @@ -91,7 +91,7 @@ export const DefaultNotificationItem = createWidget( return iconNode(`notification.${notificationName}`); }, - title(notificationName) { + notificationTitle(notificationName) { if (notificationName) { return I18n.t(`notifications.titles.${notificationName}`); } else { @@ -108,7 +108,7 @@ export const DefaultNotificationItem = createWidget( let text = emojiUnescape(this.text(notificationName, data)); let icon = this.icon(notificationName, data); - const title = this.title(notificationName, data); + const title = this.notificationTitle(notificationName, data); // We can use a `

` tag here once other languages have fixed their HTML // translations.