IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: ensures slug and id are not arrays (#8495)

Browse Source 
If for some reason an URL was create in this format:

```
?slug[]=foo&slug[]=bar
```

This would have create an exception of this kind:

```
NoMethodError (undefined method `tr' for ["foo", "bar"]:Array
Did you mean?  try)
```
This commit is contained in:
Joffrey JAFFEUX 2019-12-10 09:28:51 +01:00 committed by GitHub
parent f5396e2700
commit 47731175f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/controllers/application_controller.rb
View File

@ -790,6 +790,9 @@ class ApplicationController < ActionController::Base
@title = opts[:title] || I18n.t("page_not_found.title") @title = opts[:title] || I18n.t("page_not_found.title")
@group = opts[:group] @group = opts[:group]
@hide_search = true if SiteSetting.login_required @hide_search = true if SiteSetting.login_required
params[:slug] = params[:slug].first if params[:slug].kind_of?(Array)
params[:id] = params[:id].first if params[:id].kind_of?(Array)
@slug = (params[:slug].presence || params[:id].presence || "").tr('-', ' ') @slug = (params[:slug].presence || params[:id].presence || "").tr('-', ' ')
render_to_string status: opts[:status], layout: opts[:layout], formats: [:html], template: '/exceptions/not_found' render_to_string status: opts[:status], layout: opts[:layout], formats: [:html], template: '/exceptions/not_found'