IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: unconditionally focus modals (#13179)

Browse Source 
Previously auto focus would only work on modals that include buttons or
inputs.

To avoid a situation where information modals such as keyboard shortcuts
do not get focus, simply focus on the close button as a fallback.
This commit is contained in:
Sam 2021-05-27 11:45:12 +10:00 committed by GitHub
parent 34c5df2700
commit 489535e5c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/components/d-modal.js
View File

@ -141,6 +141,10 @@ export default Component.extend({
focusTarget = this.element.querySelector(
".modal-body input, .modal-body button, .modal-footer input, .modal-footer button"
);
if (!focusTarget) {
focusTarget = this.element.querySelector(".modal-header button");
}
}
if (focusTarget) {
afterTransition(() => focusTarget.focus());