From 4a74f18e95d04578b1461788de3635fc35edbf06 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Mon, 11 May 2020 09:34:00 +0800 Subject: [PATCH] PERF: Move fetching of avatar into hijack for discobot certificate --- plugins/discourse-narrative-bot/plugin.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/discourse-narrative-bot/plugin.rb b/plugins/discourse-narrative-bot/plugin.rb index 29766f640e8..a6be5dd056f 100644 --- a/plugins/discourse-narrative-bot/plugin.rb +++ b/plugins/discourse-narrative-bot/plugin.rb @@ -92,10 +92,10 @@ after_initialize do user = User.find_by(id: params[:user_id]) raise Discourse::NotFound if user.blank? - cdn_avatar_url = fetch_avatar_url(user) hijack do - generator = CertificateGenerator.new(user, params[:date], cdn_avatar_url) + avatar_data = fetch_avatar(user) + generator = CertificateGenerator.new(user, params[:date], avatar_data) svg = params[:type] == 'advanced' ? generator.advanced_user_track : generator.new_user_track @@ -107,7 +107,7 @@ after_initialize do private - def fetch_avatar_url(user) + def fetch_avatar(user) avatar_url = UrlHelper.absolute(Discourse.base_uri + user.avatar_template.gsub('{size}', '250')) FileHelper.download( avatar_url.to_s,