IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Preload uploads in groups#search to stop N+1 (#10814)

Browse Source 
`BasicGroupSerializer` includes `flair_url` which uses `flair_upload` relation, so the N in N+1 in this case was the number of groups with flair in the forum.
This commit is contained in:
Jarek Radosz 2020-10-05 10:22:55 +02:00 committed by GitHub
parent 01a9c57dcb
commit 4b5358bb42
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/groups_controller.rb
View File

@ -537,6 +537,7 @@ class GroupsController < ApplicationController
def search def search
groups = Group.visible_groups(current_user) groups = Group.visible_groups(current_user)
.where("groups.id <> ?", Group::AUTO_GROUPS[:everyone]) .where("groups.id <> ?", Group::AUTO_GROUPS[:everyone])
.includes(:flair_upload)
.order(:name) .order(:name)
if (term = params[:term]).present? if (term = params[:term]).present?