IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Topic.similar_to results in invalid query for certain locales. (#14497)

Browse Source 
For `zh_CN`, we use the `cppjieba_rb` gem to remove stop words so
calling `Search.prepare_data` may result in an empty string.
This commit is contained in:
Alan Guo Xiang Tan 2021-10-04 11:40:22 +08:00 committed by GitHub
parent aba08d1929
commit 4cade9d7f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/models/topic.rb
View File

@ -581,11 +581,11 @@ class Topic < ActiveRecord::Base
def self.similar_to(title, raw, user = nil) def self.similar_to(title, raw, user = nil)
return [] if title.blank? return [] if title.blank?
raw = raw.presence || "" raw = raw.presence || ""
search_data = Search.prepare_data(title.strip)
tsquery = Search.set_tsquery_weight_filter( return [] if search_data.blank?
Search.prepare_data(title.strip),
'A' tsquery = Search.set_tsquery_weight_filter(search_data, 'A')
)
if raw.present? if raw.present?
cooked = SearchIndexer::HtmlScrubber.scrub( cooked = SearchIndexer::HtmlScrubber.scrub(

6
spec/models/topic_spec.rb
View File

@ -540,6 +540,12 @@ describe Topic do
expect(Topic.similar_to('some title', 'https://discourse.org/#INCORRECT#URI')).to be_empty expect(Topic.similar_to('some title', 'https://discourse.org/#INCORRECT#URI')).to be_empty
end end
it 'does not result in invalid statement when title is all stopwords for zh_CN' do
SiteSetting.default_locale = "zh_CN"
expect(Topic.similar_to("怎么上自己的", '')).to eq([])
end
context 'with a similar topic' do context 'with a similar topic' do
fab!(:post) { fab!(:post) {
SearchIndexer.enable SearchIndexer.enable