IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-12 05:55:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Include pending reviewables in the main tab in the user menu (#18471)

Browse Source 
This commit makes pending reviewables show up in the main tab (a.k.a. "all notifications" tab). Pending reviewables along with unread notifications are always shown first and they're sorted based on their creation date (most recent comes first).

The dismiss button currently only shows up if there are unread notifications and it doesn't dismiss pending reviewables. We may follow up with another change soon that allows makes the dismiss button work with reviewables and remove them from the list without taking any action on them. 

Follow-up to https://github.com/discourse/discourse/commit/079450c9e496ac9bed8ff491ceb1e4ac0b83448f.
This commit is contained in:
Osama Sayegh
2022-10-05 12:30:02 +03:00
committed by GitHub
parent c0037dc0f0
commit 4d05e3edab
12 changed files with 394 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/support/common_basic_reviewable_serializer.rb
+8
View File
@@ -38,4 +38,12 @@ shared_examples "basic reviewable attributes" do
expect(subject[:flagger_username]).to eq("gg.osama")
end
end
describe "#created_at" do
it "serializes the reviewable's created_at field correctly" do
time = 10.minutes.ago
reviewable.update!(created_at: time)
expect(subject[:created_at]).to eq(time)
end
end
end