UX: Move group mentions notifications into the reply tab (#22562)

Why this change?

Group mention notifications are currently placed in the "Others" tab
of the user menu which is odd considering that mentioned notifications
are in the reply tab. This commit changes it such that group mention
notifications are displayed in the reply tab as well.
This commit is contained in:
Alan Guo Xiang Tan
2023-07-13 06:52:03 +08:00
committed by GitHub
parent b697cf9dc2
commit 4d5f9b8a21
4 changed files with 73 additions and 3 deletions

View File

@@ -37,11 +37,18 @@ const CORE_TOP_TABS = [
id = "replies";
icon = "reply";
panelComponent = UserMenuRepliesNotificationsList;
notificationTypes = ["mentioned", "posted", "quoted", "replied"];
notificationTypes = [
"mentioned",
"group_mentioned",
"posted",
"quoted",
"replied",
];
get count() {
return (
this.getUnreadCountForType("mentioned") +
this.getUnreadCountForType("group_mentioned") +
this.getUnreadCountForType("posted") +
this.getUnreadCountForType("quoted") +
this.getUnreadCountForType("replied")

View File

@@ -222,7 +222,8 @@ module("Integration | Component | user-menu", function (hooks) {
},
];
} else if (
queryParams.filter_by_types === "mentioned,posted,quoted,replied"
queryParams.filter_by_types ===
"mentioned,group_mentioned,posted,quoted,replied"
) {
data = [
{
@@ -280,7 +281,7 @@ module("Integration | Component | user-menu", function (hooks) {
assert.ok(exists("#quick-access-replies.quick-access-panel"));
assert.strictEqual(
queryParams.filter_by_types,
"mentioned,posted,quoted,replied",
"mentioned,group_mentioned,posted,quoted,replied",
"request params has filter_by_types set to `mentioned`, `posted`, `quoted` and `replied`"
);
assert.strictEqual(queryParams.silent, "true");