IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Clicking on quote button was tricky

Browse Source
This commit is contained in:
Robin Ward 2017-10-06 21:29:16 -04:00
parent 193244f8c1
commit 4da4f986ee
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/components/quote-button.js.es6
View File

@ -1,11 +1,5 @@
import { selectedText } from 'discourse/lib/utilities'; import { selectedText } from 'discourse/lib/utilities';
// we don't want to deselect when we click on buttons that use it
function willQuote(e) {
const $target = $(e.target);
return $target.hasClass('quote-button') || $target.closest('.create, .share, .reply-new').length;
}
export default Ember.Component.extend({ export default Ember.Component.extend({
classNames: ['quote-button'], classNames: ['quote-button'],
classNameBindings: ['visible'], classNameBindings: ['visible'],
@ -109,7 +103,7 @@ export default Ember.Component.extend({
$(document).on("mousedown.quote-button", e => { $(document).on("mousedown.quote-button", e => {
this._isMouseDown = true; this._isMouseDown = true;
this._reselected = false; this._reselected = false;
if (!willQuote(e)) { if ($(e.target).closest('.quote-button, .create, .share, .reply-new').length === 0) {
this._hideButton(); this._hideButton();
} }
}).on("mouseup.quote-button", () => { }).on("mouseup.quote-button", () => {