mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Single admin plugin page for consistent admin plugin UX (#26024)
This commit adds new plugin show routes (`/admin/plugins/:plugin_id`) as we move towards every plugin having a consistent UI/landing page. As part of this, we are introducing a consistent way for plugins to show an inner sidebar in their config page, via a new plugin API `register_admin_config_nav_routes` This accepts an array of links with a label/text, and an ember route. Once this commit is merged we can start the process of conforming other plugins to follow this pattern, as well as supporting a single-page version of this for simpler plugins that don't require an inner sidebar. Part of /t/122841 internally
This commit is contained in:
@@ -5,15 +5,11 @@ export default class AdminPluginsController extends Controller {
|
||||
@service router;
|
||||
|
||||
get adminRoutes() {
|
||||
return this.allAdminRoutes.filter((route) =>
|
||||
this.routeExists(route.full_location)
|
||||
);
|
||||
return this.allAdminRoutes.filter((route) => this.routeExists(route));
|
||||
}
|
||||
|
||||
get brokenAdminRoutes() {
|
||||
return this.allAdminRoutes.filter(
|
||||
(route) => !this.routeExists(route.full_location)
|
||||
);
|
||||
return this.allAdminRoutes.filter((route) => !this.routeExists(route));
|
||||
}
|
||||
|
||||
get allAdminRoutes() {
|
||||
@@ -25,9 +21,13 @@ export default class AdminPluginsController extends Controller {
|
||||
.filter(Boolean);
|
||||
}
|
||||
|
||||
routeExists(routeName) {
|
||||
routeExists(route) {
|
||||
try {
|
||||
this.router.urlFor(routeName);
|
||||
if (route.use_new_show_route) {
|
||||
this.router.urlFor(route.full_location, route.location);
|
||||
} else {
|
||||
this.router.urlFor(route.full_location);
|
||||
}
|
||||
return true;
|
||||
} catch (e) {
|
||||
return false;
|
||||
|
||||
Reference in New Issue
Block a user