IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove migrate_column_to_bigint spec helper (#29805)

Browse Source 
This spec helper was introduced as a temporary solution to the problem
of mismatched types between primary key and foreign key columns. All
plugins have been migrated and the only remaining use of this helper is
in core Discourse.
This commit is contained in:
Bianca Nenciu 2024-11-19 21:22:02 +02:00 committed by GitHub
parent 79b3cb8289
commit 4f11d16deb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
spec/rails_helper.rb
View File

@ -476,23 +476,19 @@ RSpec.configure do |config|
Capybara::Selenium::Driver.new(app, **mobile_driver_options)
end
migrate_column_to_bigint(PostAction, :post_action_type_id)
migrate_column_to_bigint(Reviewable, :target_id)
migrate_column_to_bigint(ReviewableHistory, :reviewable_id)
migrate_column_to_bigint(ReviewableScore, :reviewable_id)
migrate_column_to_bigint(ReviewableScore, :reviewable_score_type)
migrate_column_to_bigint(SidebarSectionLink, :linkable_id)
migrate_column_to_bigint(SidebarSectionLink, :sidebar_section_id)
migrate_column_to_bigint(User, :last_seen_reviewable_id)
migrate_column_to_bigint(User, :required_fields_version)
$columns_to_migrate_to_bigint.each do |model, column|
if model.is_a?(String)
DB.exec("ALTER TABLE #{model} ALTER #{column} TYPE bigint")
else
DB.exec("ALTER TABLE #{model.table_name} ALTER #{column} TYPE bigint")
model.reset_column_information
end
[
[PostAction, :post_action_type_id],
[Reviewable, :target_id],
[ReviewableHistory, :reviewable_id],
[ReviewableScore, :reviewable_id],
[ReviewableScore, :reviewable_score_type],
[SidebarSectionLink, :linkable_id],
[SidebarSectionLink, :sidebar_section_id],
[User, :last_seen_reviewable_id],
[User, :required_fields_version],
].each do |model, column|
DB.exec("ALTER TABLE #{model.table_name} ALTER #{column} TYPE bigint")
model.reset_column_information
end
# Sets sequence's value to be greater than the max value that an INT column can hold. This is done to prevent
@ -1050,10 +1046,6 @@ def apply_base_chrome_options(options)
end
end
def migrate_column_to_bigint(model, column)
($columns_to_migrate_to_bigint ||= []) << [model, column]
end
class SpecSecureRandom
class << self
attr_accessor :value