Refactor UsersController#create

* Simplify controller action
* Extract service classes
This commit is contained in:
Scott Albertson
2013-12-05 10:11:16 -08:00
parent 13da653f2b
commit 51eff92170
4 changed files with 115 additions and 78 deletions
-59
View File
@@ -1,59 +0,0 @@
# Responsible for dealing with different activation processes when a user is created
class UserActivator
attr_reader :user, :request, :session, :cookies
def initialize(user, request, session, cookies)
@user = user
@session = session
@cookies = cookies
@request = request
end
def activation_message
activator.activate
end
private
def activator
factory.new(user, request, session, cookies)
end
def factory
if SiteSetting.must_approve_users?
ApprovalActivator
elsif !user.active?
EmailActivator
else
LoginActivator
end
end
end
class ApprovalActivator < UserActivator
def activate
I18n.t("login.wait_approval")
end
end
class EmailActivator < UserActivator
def activate
Jobs.enqueue(:user_email,
type: :signup,
user_id: user.id,
email_token: user.email_tokens.first.token
)
I18n.t("login.activate_email", email: user.email)
end
end
class LoginActivator < UserActivator
include CurrentUser
def activate
log_on_user(user)
user.enqueue_welcome_message('welcome_user')
I18n.t("login.active")
end
end