From 52332ccd72243412d7846aaa92eb18a62916dbc9 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Tue, 26 Mar 2019 16:31:48 +0100 Subject: [PATCH] FIX: uses aria-label instead of title as it's useless with popover (#7258) --- .../assets/javascripts/discourse-local-dates.js.no-module.es6 | 2 +- .../lib/discourse-markdown/discourse-local-dates.js.es6 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/discourse-local-dates/assets/javascripts/discourse-local-dates.js.no-module.es6 b/plugins/discourse-local-dates/assets/javascripts/discourse-local-dates.js.no-module.es6 index e50d73545aa..4c96ae006fb 100644 --- a/plugins/discourse-local-dates/assets/javascripts/discourse-local-dates.js.no-module.es6 +++ b/plugins/discourse-local-dates/assets/javascripts/discourse-local-dates.js.no-module.es6 @@ -69,7 +69,7 @@ $element .html(DATE_TEMPLATE) - .attr("title", textPreview) + .attr("aria-label", textPreview) .attr("data-html-tooltip", `
${htmlPreview}
`) .addClass("cooked-date") .find(".relative-time") diff --git a/plugins/discourse-local-dates/assets/javascripts/lib/discourse-markdown/discourse-local-dates.js.es6 b/plugins/discourse-local-dates/assets/javascripts/lib/discourse-markdown/discourse-local-dates.js.es6 index 7105464ba81..1a174b22885 100644 --- a/plugins/discourse-local-dates/assets/javascripts/lib/discourse-markdown/discourse-local-dates.js.es6 +++ b/plugins/discourse-local-dates/assets/javascripts/lib/discourse-markdown/discourse-local-dates.js.es6 @@ -130,7 +130,7 @@ export function setup(helper) { helper.whiteList([ "span.discourse-local-date", "span[data-*]", - "span[title]" + "span[aria-label]" ]); helper.registerOptions((opts, siteSettings) => {