DEV: apply new coding standards (#10592)

This commit is contained in:
Joffrey JAFFEUX
2020-09-04 13:42:47 +02:00
committed by GitHub
parent 80dfaeb0d2
commit 52672b9eab
1473 changed files with 9386 additions and 9958 deletions
+39 -49
View File
@@ -7,14 +7,14 @@ function preferencesPretender(server, helper) {
server.post("/u/second_factors.json", () => {
return helper.response({
success: "OK",
password_required: "true"
password_required: "true",
});
});
server.post("/u/create_second_factor_totp.json", () => {
return helper.response({
key: "rcyryaqage3jexfj",
qr: '<div id="test-qr">qr-code</div>'
qr: '<div id="test-qr">qr-code</div>',
});
});
@@ -23,7 +23,7 @@ function preferencesPretender(server, helper) {
challenge: "a6d393d12654c130b2273e68ca25ca232d1d7f4c2464c2610fb8710a89d4",
rp_id: "localhost",
rp_name: "Discourse",
supported_algorithms: [-7, -257]
supported_algorithms: [-7, -257],
});
});
@@ -33,26 +33,26 @@ function preferencesPretender(server, helper) {
server.put("/u/second_factors_backup.json", () => {
return helper.response({
backup_codes: ["dsffdsd", "fdfdfdsf", "fddsds"]
backup_codes: ["dsffdsd", "fdfdfdsf", "fddsds"],
});
});
server.post("/u/eviltrout/preferences/revoke-account", () => {
return helper.response({
success: true
success: true,
});
});
server.put("/u/eviltrout/preferences/email", () => {
return helper.response({
success: true
success: true,
});
});
server.post("/user_avatar/eviltrout/refresh_gravatar.json", () => {
return helper.response({
gravatar_upload_id: 6543,
gravatar_avatar_template: "/images/avatar.png"
gravatar_avatar_template: "/images/avatar.png",
});
});
@@ -63,10 +63,10 @@ function preferencesPretender(server, helper) {
acceptance("User Preferences", {
loggedIn: true,
pretend: preferencesPretender
pretend: preferencesPretender,
});
QUnit.test("update some fields", async assert => {
QUnit.test("update some fields", async (assert) => {
await visit("/u/eviltrout/preferences");
assert.ok($("body.user-preferences-page").length, "has the body class");
@@ -121,12 +121,12 @@ QUnit.test("update some fields", async assert => {
);
});
QUnit.test("username", async assert => {
QUnit.test("username", async (assert) => {
await visit("/u/eviltrout/preferences/username");
assert.ok(exists("#change_username"), "it has the input element");
});
QUnit.test("email", async assert => {
QUnit.test("email", async (assert) => {
await visit("/u/eviltrout/preferences/email");
assert.ok(exists("#change-email"), "it has the input element");
@@ -134,15 +134,13 @@ QUnit.test("email", async assert => {
await fillIn("#change-email", "invalidemail");
assert.equal(
find(".tip.bad")
.text()
.trim(),
find(".tip.bad").text().trim(),
I18n.t("user.email.invalid"),
"it should display invalid email tip"
);
});
QUnit.test("email field always shows up", async assert => {
QUnit.test("email field always shows up", async (assert) => {
await visit("/u/eviltrout/preferences/email");
assert.ok(exists("#change-email"), "it has the input element");
@@ -156,7 +154,7 @@ QUnit.test("email field always shows up", async assert => {
assert.ok(exists("#change-email"), "it has the input element");
});
QUnit.test("connected accounts", async assert => {
QUnit.test("connected accounts", async (assert) => {
await visit("/u/eviltrout/preferences/account");
assert.ok(
@@ -177,7 +175,7 @@ QUnit.test("connected accounts", async assert => {
.indexOf("Connect") > -1;
});
QUnit.test("second factor totp", async assert => {
QUnit.test("second factor totp", async (assert) => {
await visit("/u/eviltrout/preferences/second-factor");
assert.ok(exists("#password"), "it has a password input");
@@ -192,14 +190,12 @@ QUnit.test("second factor totp", async assert => {
await click(".add-totp");
assert.ok(
find(".alert-error")
.html()
.indexOf("provide a name and the code") > -1,
find(".alert-error").html().indexOf("provide a name and the code") > -1,
"shows name/token missing error message"
);
});
QUnit.test("second factor security keys", async assert => {
QUnit.test("second factor security keys", async (assert) => {
await visit("/u/eviltrout/preferences/second-factor");
assert.ok(exists("#password"), "it has a password input");
@@ -219,15 +215,13 @@ QUnit.test("second factor security keys", async assert => {
await click(".add-security-key");
assert.ok(
find(".alert-error")
.html()
.indexOf("provide a name") > -1,
find(".alert-error").html().indexOf("provide a name") > -1,
"shows name missing error message"
);
}
});
QUnit.test("default avatar selector", async assert => {
QUnit.test("default avatar selector", async (assert) => {
await visit("/u/eviltrout/preferences");
await click(".pref-avatar .btn");
@@ -248,22 +242,22 @@ acceptance("Second Factor Backups", {
server.post("/u/second_factors.json", () => {
return helper.response({
success: "OK",
totps: [{ id: 1, name: "one of them" }]
totps: [{ id: 1, name: "one of them" }],
});
});
server.put("/u/second_factors_backup.json", () => {
return helper.response({
backup_codes: ["dsffdsd", "fdfdfdsf", "fddsds"]
backup_codes: ["dsffdsd", "fdfdfdsf", "fddsds"],
});
});
server.get("/u/eviltrout/activity.json", () => {
return helper.response({});
});
}
},
});
QUnit.test("second factor backup", async assert => {
QUnit.test("second factor backup", async (assert) => {
updateCurrentUser({ second_factor_enabled: true });
await visit("/u/eviltrout/preferences/second-factor");
await click(".edit-2fa-backup");
@@ -284,13 +278,13 @@ acceptance("Avatar selector when selectable avatars is enabled", {
return [
200,
{ "Content-Type": "application/json" },
["https://www.discourse.org", "https://meta.discourse.org"]
["https://www.discourse.org", "https://meta.discourse.org"],
];
});
}
},
});
QUnit.test("selectable avatars", async assert => {
QUnit.test("selectable avatars", async (assert) => {
await visit("/u/eviltrout/preferences");
await click(".pref-avatar .btn");
@@ -301,10 +295,10 @@ QUnit.test("selectable avatars", async assert => {
acceptance("User Preferences when badges are disabled", {
loggedIn: true,
settings: { enable_badges: false },
pretend: preferencesPretender
pretend: preferencesPretender,
});
QUnit.test("visit my preferences", async assert => {
QUnit.test("visit my preferences", async (assert) => {
await visit("/u/eviltrout/preferences");
assert.ok($("body.user-preferences-page").length, "has the body class");
assert.equal(
@@ -315,21 +309,17 @@ QUnit.test("visit my preferences", async assert => {
assert.ok(exists(".user-preferences"), "it shows the preferences");
});
QUnit.test("recently connected devices", async assert => {
QUnit.test("recently connected devices", async (assert) => {
await visit("/u/eviltrout/preferences");
assert.equal(
find(".auth-tokens > .auth-token:first .auth-token-device")
.text()
.trim(),
find(".auth-tokens > .auth-token:first .auth-token-device").text().trim(),
"Linux Computer",
"it should display active token first"
);
assert.equal(
find(".pref-auth-tokens > a:first")
.text()
.trim(),
find(".pref-auth-tokens > a:first").text().trim(),
I18n.t("user.auth_tokens.show_all", { count: 3 }),
"it should display two tokens"
);
@@ -367,14 +357,14 @@ acceptance(
pretend(server, helper) {
server.put("/u/eviltrout/feature-topic", () => {
return helper.response({
success: true
success: true,
});
});
}
},
}
);
QUnit.test("setting featured topic on profile", async assert => {
QUnit.test("setting featured topic on profile", async (assert) => {
await visit("/u/eviltrout/preferences/profile");
assert.ok(
@@ -418,14 +408,14 @@ acceptance("Custom User Fields", {
name: "What kind of pet do you have?",
field_type: "dropdown",
options: ["Dog", "Cat", "Hamster"],
required: true
}
]
required: true,
},
],
},
pretend: preferencesPretender
pretend: preferencesPretender,
});
QUnit.test("can select an option from a dropdown", async assert => {
QUnit.test("can select an option from a dropdown", async (assert) => {
await visit("/u/eviltrout/preferences/profile");
assert.ok(exists(".user-field"), "it has at least one user field");
await click(".user-field.dropdown");