From 54a01701d70829c87307ea3fe8ae8cec7b3bafdd Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Wed, 20 Jan 2021 15:57:38 +0100 Subject: [PATCH] DEV: makes user-stream an unordered list (#11770) Note, ideally we would drop tagName usage, but I think it's safer to do it in a separate PR in few weeks. --- .../javascripts/discourse/app/components/user-stream-item.js | 2 ++ app/assets/javascripts/discourse/app/components/user-stream.js | 2 ++ app/assets/stylesheets/common/components/user-stream-item.scss | 1 + 3 files changed, 5 insertions(+) diff --git a/app/assets/javascripts/discourse/app/components/user-stream-item.js b/app/assets/javascripts/discourse/app/components/user-stream-item.js index b80903845c3..68cfb4816f4 100644 --- a/app/assets/javascripts/discourse/app/components/user-stream-item.js +++ b/app/assets/javascripts/discourse/app/components/user-stream-item.js @@ -4,6 +4,8 @@ import { computed } from "@ember/object"; import { propertyEqual } from "discourse/lib/computed"; export default Component.extend({ + tagName: "li", + classNameBindings: [ ":user-stream-item", ":item", // DEPRECATED: 'item' class diff --git a/app/assets/javascripts/discourse/app/components/user-stream.js b/app/assets/javascripts/discourse/app/components/user-stream.js index b57117e88f2..3d1c1e6b9ec 100644 --- a/app/assets/javascripts/discourse/app/components/user-stream.js +++ b/app/assets/javascripts/discourse/app/components/user-stream.js @@ -13,6 +13,8 @@ import { popupAjaxError } from "discourse/lib/ajax-error"; import { schedule } from "@ember/runloop"; export default Component.extend(LoadMore, { + tagName: "ul", + _initialize: on("init", function () { const filter = this.get("stream.filter"); if (filter) { diff --git a/app/assets/stylesheets/common/components/user-stream-item.scss b/app/assets/stylesheets/common/components/user-stream-item.scss index 7adfd57caab..d027e22e46f 100644 --- a/app/assets/stylesheets/common/components/user-stream-item.scss +++ b/app/assets/stylesheets/common/components/user-stream-item.scss @@ -10,6 +10,7 @@ background-color: var(--secondary); border-bottom: 1px solid var(--primary-low); padding: 1em 0.53em; + list-style: none; &.moderator-action { background-color: var(--highlight-medium);