IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Ensure topic exists before making a banner. (#7781)

Browse Source
This commit is contained in:
Bianca Nenciu 2019-06-25 13:49:29 +03:00 committed by GitHub
parent 3fd7cf9038
commit 557805249d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/guardian/topic_guardian.rb
View File

@ -174,6 +174,6 @@ module TopicGuardian
end end
def can_banner_topic?(topic) def can_banner_topic?(topic)
authenticated? && !topic.private_message? && is_staff? topic && authenticated? && !topic.private_message? && is_staff?
end end
end end

7
spec/components/guardian_spec.rb
View File

@ -776,6 +776,13 @@ describe Guardian do
PostActionCreator.create(user, first_post, :off_topic) PostActionCreator.create(user, first_post, :off_topic)
expect(Guardian.new(moderator).can_see?(private_topic)).to be_truthy expect(Guardian.new(moderator).can_see?(private_topic)).to be_truthy
end end
it "allows staff to set banner topics" do
topic = Fabricate(:topic)
expect(Guardian.new(admin).can_banner_topic?(nil)).to be_falsey
expect(Guardian.new(admin).can_banner_topic?(topic)).to be_truthy
end
end end
describe 'a Post' do describe 'a Post' do