Rename handle_exception to handle_job_exception

This commit is contained in:
riking
2015-02-09 12:47:46 -08:00
parent b7f45f6667
commit 5657006aca
13 changed files with 23 additions and 23 deletions

View File

@@ -139,7 +139,7 @@ describe Discourse do
it "should not fail when called" do
exception = StandardError.new
Discourse.handle_exception(exception, nil, nil)
Discourse.handle_job_exception(exception, nil, nil)
expect(logger.exception).to eq(exception)
expect(logger.context.keys).to eq([:current_db, :current_hostname])
end
@@ -147,7 +147,7 @@ describe Discourse do
it "correctly passes extra context" do
exception = StandardError.new
Discourse.handle_exception(exception, {message: "Doing a test", post_id: 31}, nil)
Discourse.handle_job_exception(exception, {message: "Doing a test", post_id: 31}, nil)
expect(logger.exception).to eq(exception)
expect(logger.context.keys.sort).to eq([:current_db, :current_hostname, :message, :post_id].sort)
end

View File

@@ -19,7 +19,7 @@ describe Jobs::Base do
raise StandardError
end
end
it 'handles correct jobs' do
job = GoodJob.new
job.perform({})
@@ -29,9 +29,9 @@ describe Jobs::Base do
it 'handles errors in multisite' do
RailsMultisite::ConnectionManagement.expects(:all_dbs).returns(['default','default','default'])
# one exception per database
Discourse.expects(:handle_exception).times(3)
Discourse.expects(:handle_job_exception).times(3)
bad = BadJob.new
bad = BadJob.new
expect{bad.perform({})}.to raise_error
expect(bad.fail_count).to eq(3)
end

View File

@@ -34,7 +34,7 @@ describe Jobs::PollMailbox do
Net::POP3.any_instance.expects(:start).raises(error)
Discourse.expects(:handle_exception)
Discourse.expects(:handle_job_exception)
poller.poll_pop3
end