From 56b777770554abbb1c1431311d76e451dcab295c Mon Sep 17 00:00:00 2001 From: Vinoth Kannan Date: Thu, 20 Jun 2019 17:27:32 +0530 Subject: [PATCH] FIX: 'status' param change not filtering the topics in tag route. Use existing 'filterQueryParams' helper method to set 'queryParams' value for tag route. --- .../discourse/routes/tags-show.js.es6 | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/app/assets/javascripts/discourse/routes/tags-show.js.es6 b/app/assets/javascripts/discourse/routes/tags-show.js.es6 index a538c4f5efa..49a4231d178 100644 --- a/app/assets/javascripts/discourse/routes/tags-show.js.es6 +++ b/app/assets/javascripts/discourse/routes/tags-show.js.es6 @@ -1,15 +1,16 @@ import Composer from "discourse/models/composer"; import showModal from "discourse/lib/show-modal"; -import { findTopicList } from "discourse/routes/build-topic-route"; +import { + filterQueryParams, + findTopicList +} from "discourse/routes/build-topic-route"; +import { queryParams } from "discourse/controllers/discovery-sortable"; import PermissionType from "discourse/models/permission-type"; export default Discourse.Route.extend({ navMode: "latest", - queryParams: { - ascending: { refreshModel: true }, - order: { refreshModel: true } - }, + queryParams, renderTemplate() { const controller = this.controllerFor("tags.show"); @@ -69,10 +70,7 @@ export default Discourse.Route.extend({ const controller = this.controllerFor("tags.show"); controller.set("loading", true); - const params = controller.getProperties("order", "ascending"); - params.order = transition.to.queryParams.order || params.order; - params.ascending = transition.to.queryParams.ascending || params.ascending; - + const params = filterQueryParams(transition.to.queryParams, {}); const categorySlug = this.categorySlug; const parentCategorySlug = this.parentCategorySlug; const filter = this.navMode;