FIX: Badge and user title interaction fixes (#8282)

* Fix user title logic when badge name customized
* Fix an issue where a user's title was not considered a badge granted title when the user used a badge for their title and the badge name was customized. this affected the effectiveness of revoke_ungranted_titles! which only operates on badge_granted_titles.
* When a user's title is set now it is considered a badge_granted_title if the badge name OR the badge custom name from TranslationOverride is the same as the title
* When a user's badge is revoked we now also revoke their title if the user's title matches the badge name OR the badge custom name from TranslationOverride
* Add a user history log when the title is revoked to remove confusion about why titles are revoked
* Add granted_title_badge_id to user_profile, now when we set badge_granted_title on a user profile when updating a user's title based on a badge, we also remember which badge matched the title
* When badge name (or custom text) changes update titles of users in a background job
* When the name of a badge changes, or in the case of system badges when their custom translation text changes, then we need to update the title of all corresponding users who have a badge_granted_title and matching granted_title_badge_id. In the case of system badges we need to first get the proper badge ID based on the translation key e.g. badges.regular.name
* Add migration to backfill all granted_title_badge_ids for both normal badge name titles and titles using custom badge text.
This commit is contained in:
Martin Brennan
2019-11-08 15:34:24 +10:00
committed by GitHub
parent 64b4a7ba45
commit 56d3e29a69
19 changed files with 397 additions and 14 deletions

View File

@@ -0,0 +1,35 @@
# frozen_string_literal: true
class AddGrantedTitleBadgeIdToUserProfile < ActiveRecord::Migration[6.0]
def up
add_reference :user_profiles, :granted_title_badge, foreign_key: { to_table: :badges }, index: true, null: true
# update all the regular badge derived titles based
# on the normal badge name
ActiveRecord::Base.connection.execute <<-SQL
UPDATE user_profiles
SET granted_title_badge_id = b.id
FROM users
INNER JOIN badges b ON users.title = b.name
WHERE users.id = user_profiles.user_id
AND user_profiles.granted_title_badge_id IS NULL
SQL
# update all of the system badge derived titles where the
# badge has had custom text set for it via TranslationOverride
ActiveRecord::Base.connection.execute <<-SQL
UPDATE user_profiles
SET granted_title_badge_id = badges.id
FROM users
JOIN translation_overrides ON translation_overrides.value = users.title
JOIN badges ON ('badges.' || LOWER(REPLACE(badges.name, ' ', '_')) || '.name') = translation_overrides.translation_key
JOIN user_badges ON user_badges.user_id = users.id AND user_badges.badge_id = badges.id
WHERE users.id = user_profiles.user_id
AND user_profiles.granted_title_badge_id IS NULL
SQL
end
def down
remove_column :user_profiles, :granted_title_badge_id
end
end