IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-01 21:19:41 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: paste table with multiline cell (#12194)

Browse Source 
When a cell is multiline, it is wrapped with quotes. It can be used to determine if it is a "real" new line or not.

Meta: https://meta.discourse.org/t/pasting-google-sheets-table-with-a-cell-that-contain-a-line-break/173106
This commit is contained in:
Krzysztof Kotlarek 2021-02-25 09:39:54 +11:00 committed by GitHub
parent 362dd798ae
commit 57bfc398d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/assets/javascripts/discourse/app/components/d-editor.js
View File

@ -883,7 +883,19 @@ export default Component.extend({
text = text.substring(0, text.length - 1);
}
let rows = text.split("\n");
text = text.split("");
let cell = false;
text.forEach((char, index) => {
if (char === "\n" && cell) {
text[index] = "\r";
}
if (char === '"') {
text[index] = "";
cell = !cell;
}
});
let rows = text.join("").replace(/\r/g, "<br>").split("\n");
if (rows.length > 1) {
const columns = rows.map((r) => r.split("\t").length);

5
app/assets/javascripts/discourse/tests/integration/components/d-editor-test.js
View File

@ -721,6 +721,11 @@ third line`
let element = queryAll(".d-editor")[0];
await paste(element, "\ta\tb\n1\t2\t3");
assert.equal(this.value, "||a|b|\n|---|---|---|\n|1|2|3|\n");
this.set("value", "");
await paste(element, '\ta\tb\n1\t"2\n2.5"\t3');
assert.equal(this.value, "||a|b|\n|---|---|---|\n|1|2<br>2.5|3|\n");
},
});