IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Correct error handling in run-qunit

Browse Source 
runAllTests is an async function, so the try/catch block does not help. The function always returns a promise, so we need to use `.catch` to handle errors. Previously, raised errors were ignored, and the process continued running until it timed out.
This commit is contained in:
David Taylor 2019-12-11 16:50:31 +00:00
parent 4e130f1e03
commit 584021ca38
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/run-qunit.js
View File

@ -127,12 +127,10 @@ async function runAllTests() {
}); });
} }
try { runAllTests().catch(e => {
runAllTests();
} catch (e) {
console.log("Failed to run tests: " + e); console.log("Failed to run tests: " + e);
process.exit(1); process.exit(1);
} });
// The following functions are converted to strings // The following functions are converted to strings
// And then sent to chrome to be evalaluated // And then sent to chrome to be evalaluated