From 5a8451bf892fa2e2438f131a9319f6041920a2c4 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 26 Mar 2019 17:59:05 +1100 Subject: [PATCH] PERF: no need to select entire group just to find name Note, this is a very good candidate for some cache longer term to cut the query out --- app/helpers/application_helper.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 22c24fafb32..0f9c896da70 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -125,7 +125,9 @@ module ApplicationHelper result << "category-#{@category.url.sub(/^\/c\//, '').gsub(/\//, '-')}" end - if current_user.present? && primary_group_name = current_user.primary_group&.name + if current_user.present? && + current_user.primary_group_id && + primary_group_name = Group.where(id: current_user.primary_group_id).pluck(:name).first result << "primary-group-#{primary_group_name.downcase}" end