From 5b031945f7038875f2d2c10df02e6cc7b9eb90a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Saquetim?= <1108771+megothss@users.noreply.github.com> Date: Wed, 24 Sep 2025 15:32:13 -0300 Subject: [PATCH] DEV: Replace the use of Ember's .findBy for native methods on arrays (#34557) Use the native array `.find` instead of Ember's `.findBy` which was deprecated. --- .../components/admin-config-areas/about.gjs | 2 +- .../admin/addon/components/admin-report.gjs | 2 +- .../admin/addon/components/emoji-value-list.gjs | 2 +- .../addon/components/form-template/form.gjs | 2 +- .../addon/controllers/admin-api-keys-new.js | 4 +++- .../admin-customize-themes-show-index.js | 2 +- .../controllers/admin-logs-staff-action-logs.js | 5 +++-- .../admin/addon/controllers/admin-user-index.js | 4 +++- .../controllers/admin-watched-words-action.js | 6 ++++-- .../admin/addon/lib/color-scheme-manager.js | 2 +- .../admin/addon/models/user-field.js | 2 +- .../admin/addon/routes/admin-badges/award.js | 4 +++- .../admin/addon/routes/admin-badges/show.js | 4 +++- .../addon/routes/admin-config-flags-edit.js | 4 +++- .../addon/routes/admin-customize-themes-edit.js | 4 +++- .../admin-customize-themes-show-schema.js | 4 +++- .../addon/routes/admin-customize-themes-show.js | 4 +++- .../addon/routes/admin-email-templates-edit.js | 2 +- .../routes/admin-site-settings-category.js | 5 ++--- .../discourse/app/components/badge-title.gjs | 4 ++-- .../app/components/basic-topic-list.gjs | 4 +++- .../app/components/composer-editor.gjs | 4 ++-- .../app/components/edit-category-security.gjs | 2 +- .../app/components/emoji-picker/content.gjs | 4 ++-- .../discourse/app/components/invite-panel.gjs | 2 +- .../app/components/modal/bulk-topic-actions.gjs | 4 +++- .../app/components/modal/reorder-categories.gjs | 5 ++--- .../app/components/time-shortcut-picker.gjs | 7 +++---- .../app/components/topic-timeline/container.gjs | 5 ++--- .../app/controllers/preferences/interface.js | 17 +++++++++-------- .../discourse/app/controllers/topic.js | 16 ++++++++-------- .../discourse/app/deprecation-workflow.js | 4 ++++ .../discourse/app/lib/avatar-flair.js | 2 +- .../discourse/app/lib/flag-targets/post-flag.js | 5 ++--- .../discourse/app/lib/keyboard-shortcuts.js | 2 +- .../discourse/app/lib/post-bookmark-manager.js | 4 +++- .../discourse/app/lib/reports-loader.js | 2 +- .../javascripts/discourse/app/lib/search.js | 4 +++- .../app/lib/sidebar/custom-sections.js | 4 ++-- .../discourse/app/lib/theme-selector.js | 2 +- .../discourse/app/lib/topic-bookmark-manager.js | 4 +++- .../discourse/app/models/category.js | 12 +++++++----- .../discourse/app/models/composer.js | 2 +- .../discourse/app/models/post-stream.js | 10 ++++++---- .../javascripts/discourse/app/models/site.js | 4 ++-- .../discourse/app/models/topic-details.js | 4 ++-- .../app/models/topic-tracking-state.js | 4 ++-- .../javascripts/discourse/app/models/topic.js | 2 +- .../javascripts/discourse/app/models/user.js | 7 +++---- .../app/routes/build-category-route.js | 4 +++- .../discourse/app/routes/new-category.js | 2 +- .../discourse/app/routes/new-topic.js | 6 ++++-- .../discourse/app/services/composer.js | 5 ++--- .../javascripts/discourse/app/services/store.js | 4 +++- .../discourse/app/widgets/post-stream.js | 5 ++--- .../discourse/tests/helpers/store-pretender.js | 4 +++- .../components/select-kit/tag-drop-test.gjs | 2 +- .../discourse/tests/unit/services/store-test.js | 2 +- .../color-palettes/color-palettes-row.gjs | 4 +++- .../addon/components/flair-chooser.js | 5 ++--- .../addon/components/multi-select.gjs | 5 ++--- .../select-kit/addon/components/select-kit.js | 5 ++--- .../addon/components/single-select.gjs | 5 ++--- .../addon/lib/select-kit-prop-utils.js | 4 ++-- .../components/chat-composer-uploads.gjs | 8 ++++++-- .../discourse/components/chat-thread-list.gjs | 10 ++++------ .../discourse/initializers/chat-sidebar.js | 7 +++++-- .../controllers/admin-plugins-house-ads-show.js | 4 +++- .../routes/admin-plugins-house-ads-show.js | 5 ++--- ...plugins-show-discourse-ai-embeddings-edit.js | 2 +- ...admin-plugins-show-discourse-ai-llms-edit.js | 2 +- ...n-plugins-show-discourse-ai-personas-edit.js | 2 +- .../components/ai-embedding-editor.gjs | 5 ++--- .../discourse/components/ai-llm-editor-form.gjs | 6 ++++-- .../discourse/components/ai-persona-editor.gjs | 2 +- .../components/ai-persona-list-editor.gjs | 4 +++- .../components/ai-persona-tool-options.gjs | 2 +- .../discourse/components/ai-tool-editor.gjs | 6 ++++-- .../components/ai-tool-list-editor.gjs | 2 +- .../components/modal/ai-llm-quota-modal.gjs | 4 +++- .../discourse/components/category-calendar.gjs | 4 +++- .../components/group-timezones/index.gjs | 4 +++- .../admin-plugins-chat-integration-provider.js | 5 ++--- ...-discourse-gamification-leaderboards-show.js | 4 +++- .../discourse/components/post-policy.gjs | 9 +++++---- .../initializers/discourse-reactions.gjs | 7 ++++--- 86 files changed, 219 insertions(+), 163 deletions(-) diff --git a/app/assets/javascripts/admin/addon/components/admin-config-areas/about.gjs b/app/assets/javascripts/admin/addon/components/admin-config-areas/about.gjs index 6023bb20dc7..a2c4415c556 100644 --- a/app/assets/javascripts/admin/addon/components/admin-config-areas/about.gjs +++ b/app/assets/javascripts/admin/addon/components/admin-config-areas/about.gjs @@ -63,7 +63,7 @@ export default class AdminConfigAreasAbout extends Component { } #lookupSettingFromData(name) { - return this.args.data.findBy("setting", name); + return this.args.data.find((value) => value.setting === name); }