From 5b98161f2fc7acf01e6810c623bb1e95f769cd46 Mon Sep 17 00:00:00 2001 From: Blake Erickson Date: Thu, 23 Apr 2020 12:36:05 -0600 Subject: [PATCH] DEV: ember-cli refactor for TextField and TextArea imports (#9480) In order to be able to use ember-cli we need to fix the import statements for `TextField` and `TextArea` in the code base. The only change I don't fully understand is the one in `discourse-loader.js`, but adding the components to that file make it all work. --- app/assets/javascripts/discourse-loader.js | 10 +++++++--- .../discourse/app/components/expanding-text-area.js | 2 +- .../discourse/app/components/honeypot-input.js | 2 +- .../discourse/app/components/number-field.js | 2 +- .../javascripts/discourse/app/components/text-field.js | 2 +- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/app/assets/javascripts/discourse-loader.js b/app/assets/javascripts/discourse-loader.js index 24f879f687f..7908ab90c50 100644 --- a/app/assets/javascripts/discourse-loader.js +++ b/app/assets/javascripts/discourse-loader.js @@ -19,9 +19,7 @@ var define, requirejs; default: Ember.ArrayProxy }, "@ember/component": { - default: Ember.Component, - TextArea: Ember.TextArea, - TextField: Ember.TextField + default: Ember.Component }, "@ember/controller": { default: Ember.Controller, @@ -129,6 +127,12 @@ var define, requirejs; "@ember/component/helper": { default: Ember.Helper }, + "@ember/component/text-field": { + default: Ember.TextField + }, + "@ember/component/text-area": { + default: Ember.TextArea + }, "@ember/error": { default: Ember.error }, diff --git a/app/assets/javascripts/discourse/app/components/expanding-text-area.js b/app/assets/javascripts/discourse/app/components/expanding-text-area.js index 94c976c4d33..821f9cf69dd 100644 --- a/app/assets/javascripts/discourse/app/components/expanding-text-area.js +++ b/app/assets/javascripts/discourse/app/components/expanding-text-area.js @@ -1,4 +1,4 @@ -import { TextArea } from "@ember/component"; +import TextArea from "@ember/component/text-area"; import { schedule } from "@ember/runloop"; import { on, observes } from "discourse-common/utils/decorators"; import autosize from "discourse/lib/autosize"; diff --git a/app/assets/javascripts/discourse/app/components/honeypot-input.js b/app/assets/javascripts/discourse/app/components/honeypot-input.js index 9eb256bc12d..c3d003d0d4c 100644 --- a/app/assets/javascripts/discourse/app/components/honeypot-input.js +++ b/app/assets/javascripts/discourse/app/components/honeypot-input.js @@ -1,4 +1,4 @@ -import { TextField } from "@ember/component"; +import TextField from "discourse/components/text-field"; import { on } from "discourse-common/utils/decorators"; export default TextField.extend({ diff --git a/app/assets/javascripts/discourse/app/components/number-field.js b/app/assets/javascripts/discourse/app/components/number-field.js index 6f78cc37076..feb61f36b10 100644 --- a/app/assets/javascripts/discourse/app/components/number-field.js +++ b/app/assets/javascripts/discourse/app/components/number-field.js @@ -1,4 +1,4 @@ -import { TextField } from "@ember/component"; +import TextField from "discourse/components/text-field"; import discourseComputed from "discourse-common/utils/decorators"; export default TextField.extend({ diff --git a/app/assets/javascripts/discourse/app/components/text-field.js b/app/assets/javascripts/discourse/app/components/text-field.js index 3477520d0bc..5809d25a86c 100644 --- a/app/assets/javascripts/discourse/app/components/text-field.js +++ b/app/assets/javascripts/discourse/app/components/text-field.js @@ -1,4 +1,4 @@ -import { TextField } from "@ember/component"; +import TextField from "@ember/component/text-field"; import discourseComputed from "discourse-common/utils/decorators"; import { siteDir, isRTL, isLTR } from "discourse/lib/text-direction"; import { next, debounce, cancel } from "@ember/runloop";