IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: ignore flair_url column in group model. (#9873)

Browse Source
This commit is contained in:
Vinoth Kannan
2020-05-26 00:43:50 +05:30
committed by GitHub
parent 8825395bdc
commit 5fb9271878
3 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spec/jobs/migrate_group_flair_images_spec.rb
View File

@@ -4,6 +4,7 @@ require 'rails_helper'
RSpec.describe Jobs::MigrateGroupFlairImages do
let(:image_url) { "https://omg.aws.somestack/test.png" }
let(:group) { Fabricate(:group) }
before do
stub_request(:get, image_url).to_return(
@@ -18,7 +19,9 @@ RSpec.describe Jobs::MigrateGroupFlairImages do
end
it 'should migrate to the new group `flair_upload_id` column correctly' do
group = Fabricate(:group, flair_url: image_url)
DB.exec(<<~SQL, flair_url: image_url)
UPDATE groups SET flair_url = :flair_url WHERE id = #{group.id}
SQL
expect do
described_class.new.execute_onceoff({})
@@ -30,7 +33,7 @@ RSpec.describe Jobs::MigrateGroupFlairImages do
end
it 'should skip groups with invalid flair URLs' do
group = Fabricate(:group, flair_url: "abc")
DB.exec("UPDATE groups SET flair_url = 'abc' WHERE id = #{group.id}")
described_class.new.execute_onceoff({})
expect(Rails.logger.warnings.count).to eq(0)
end