DEV: Standardize Ember route, controller and template naming (#34417)

For historical reasons, Discourse has a customized Ember resolver. This
had a much more fuzzy implementation of 'normalize' and 'findTemplate'
functions. This leniency meant that our file naming hasn't always
matched Ember conventions.

Standardizing our naming will make things easier to understand for
developers, and will make adoption of newer ecosystem tooling easier
(e.g. route-based bundle splitting in Embroider/vite)

This commit adds deprecations to the resolver when this leniency is
used, and uses a fully bespoke codemod to rename all of the affected
routes/controllers/templates in the Discourse core repository.
Backwards-compatibility is maintained for anyone looking up the old
names in the resolver.

plugins/discourse-reactions/assets/javascripts/discourse/controllers/user-activity/reactions.js

@@ -2,7 +2,7 @@ import { tracked } from "@glimmer/tracking";
 import Controller, { inject as controller } from "@ember/controller";
 import { action } from "@ember/object";
 import { service } from "@ember/service";
-import CustomReaction from "../models/discourse-reactions-custom-reaction";
+import CustomReaction from "../../models/discourse-reactions-custom-reaction";
 
 export default class UserActivityReactions extends Controller {
   @service siteSettings;

plugins/discourse-reactions/assets/javascripts/discourse/routes/user-activity/reactions.js

@@ -1,5 +1,5 @@
 import DiscourseRoute from "discourse/routes/discourse";
-import CustomReaction from "../models/discourse-reactions-custom-reaction";
+import CustomReaction from "../../models/discourse-reactions-custom-reaction";
 
 export default class UserActivityReactions extends DiscourseRoute {
   model() {
@@ -11,7 +11,7 @@ export default class UserActivityReactions extends DiscourseRoute {
 
   setupController(controller, model) {
     let loadedAll = model.length < 20;
-    this.controllerFor("user-activity-reactions").setProperties({
+    this.controllerFor("user-activity.reactions").setProperties({
       model,
       canLoadMore: !loadedAll,
       reactionsUrl: "reactions",

plugins/discourse-reactions/assets/javascripts/discourse/routes/user-notifications/reactions-received.js

@@ -1,9 +1,9 @@
 import DiscourseRoute from "discourse/routes/discourse";
-import CustomReaction from "../models/discourse-reactions-custom-reaction";
+import CustomReaction from "../../models/discourse-reactions-custom-reaction";
 
 export default class UserNotificationsReactionsReceived extends DiscourseRoute {
-  templateName = "user-activity-reactions";
-  controllerName = "user-activity-reactions";
+  templateName = "user-activity.reactions";
+  controllerName = "user-activity.reactions";
 
   queryParams = {
     acting_username: { refreshModel: true },
@@ -23,7 +23,7 @@ export default class UserNotificationsReactionsReceived extends DiscourseRoute {
 
   setupController(controller, model) {
     let loadedAll = model.length < 20;
-    this.controllerFor("user-activity-reactions").setProperties({
+    this.controllerFor("user-activity.reactions").setProperties({
       model,
       canLoadMore: !loadedAll,
       reactionsUrl: "reactions-received",

plugins/discourse-reactions/assets/javascripts/discourse/templates/user-activity/reactions.gjs

@@ -2,7 +2,7 @@ import RouteTemplate from "ember-route-template";
 import ConditionalLoadingSpinner from "discourse/components/conditional-loading-spinner";
 import LoadMore from "discourse/components/load-more";
 import { i18n } from "discourse-i18n";
-import DiscourseReactionsReactionPost from "../components/discourse-reactions-reaction-post";
+import DiscourseReactionsReactionPost from "../../components/discourse-reactions-reaction-post";
 
 export default RouteTemplate(
   <template>