IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Improve GitHub commit, PR and issue onebox rendering

Browse Source 
Bump onebox version to include new github rendering, and add relevant CSS

Avatars are reduced in size significantly, and icons are added to easily differentiate PRs and commits. The 'Issue:' prefix is removed from issue oneboxes, to make them consistent with commits and PRs.
This commit is contained in:
David Taylor 2019-10-07 19:26:10 +01:00
parent 342b925b02
commit 615039f228
3 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Gemfile
View File

@ -50,7 +50,7 @@ gem 'redis-namespace'
gem 'active_model_serializers', '~> 0.8.3' gem 'active_model_serializers', '~> 0.8.3'
gem 'onebox', '1.9.13' gem 'onebox', '1.9.14'
gem 'http_accept_language', '~>2.0.5', require: false gem 'http_accept_language', '~>2.0.5', require: false

6
Gemfile.lock
View File

@ -245,7 +245,7 @@ GEM
omniauth-twitter (1.4.0) omniauth-twitter (1.4.0)
omniauth-oauth (~> 1.1) omniauth-oauth (~> 1.1)
rack rack
onebox (1.9.13) onebox (1.9.14)
htmlentities (~> 4.3) htmlentities (~> 4.3)
moneta (~> 1.0) moneta (~> 1.0)
multi_json (~> 1.11) multi_json (~> 1.11)
@ -360,7 +360,7 @@ GEM
ruby_dep (1.5.0) ruby_dep (1.5.0)
rubyzip (2.0.0) rubyzip (2.0.0)
safe_yaml (1.0.5) safe_yaml (1.0.5)
sanitize (5.0.0) sanitize (5.1.0)
crass (~> 1.0.2) crass (~> 1.0.2)
nokogiri (>= 1.8.0) nokogiri (>= 1.8.0)
nokogumbo (~> 2.0) nokogumbo (~> 2.0)
@ -501,7 +501,7 @@ DEPENDENCIES
omniauth-oauth2 omniauth-oauth2
omniauth-openid omniauth-openid
omniauth-twitter omniauth-twitter
onebox (= 1.9.13) onebox (= 1.9.14)
openid-redis-store openid-redis-store
parallel_tests parallel_tests
pg pg

17
app/assets/stylesheets/common/base/onebox.scss
View File

@ -378,6 +378,23 @@ pre.onebox code {
white-space: normal; white-space: normal;
} }
// Onebox - Github - PR, Commit & Issue
.onebox.githubpullrequest,
.onebox.githubcommit,
.onebox.githubissue {
.github-icon {
float: left;
margin-right: 10px;
fill: $primary-high;
}
.onebox-avatar-inline {
height: 1em;
width: 1em;
margin-right: 6px;
}
}
//Onebox - Github - Pull request //Onebox - Github - Pull request
.onebox-body .github-commit-status { .onebox-body .github-commit-status {
background: #f5f5f5; background: #f5f5f5;