IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect condition in groups:grant_badge rake task.

Browse Source 
`#find` raises an error if the id given to it is invalid. As a result,
the conditional to check whether a `group` or `badge` is `present?` will
not be executed if any of the ids are invalid.

Follow up to
6ba914033c.
This commit is contained in:
Guo Xiang Tan 2019-05-09 14:51:29 +08:00
parent 867c1a5ac9
commit 626808e100
1 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/tasks/groups.rake
View File

@ -8,10 +8,20 @@ task "groups:grant_badge", [:group_id, :badge_id] => [:environment] do |_, args|
exit 1 exit 1
end end
group = Group.find(group_id) group = Group.find_by(id: group_id)
badge = Badge.find(badge_id)
unless group
puts "ERROR: `group_id` is invalid"
exit 1
end
badge = Badge.find_by(id: badge_id)
unless badge
puts "ERROR: `badge_id` is invalid"
exit 1
end
if group.present? && badge.present?
puts "Granting badge '#{badge.name}' to all users in group '#{group.name}'..." puts "Granting badge '#{badge.name}' to all users in group '#{group.name}'..."
count = 0 count = 0
@ -23,7 +33,6 @@ task "groups:grant_badge", [:group_id, :badge_id] => [:environment] do |_, args|
end end
putc "." if (count += 1) % 5 == 0 putc "." if (count += 1) % 5 == 0
end end
end
puts "", "Done! Badge granted to #{count} members.", "" puts "", "Done! Badge granted to #{count} members.", ""
end end