From 573c4b41f03df79b7f350748636427d8a5ae9dd3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9gis=20Hanol?= <regis@hanol.fr>
Date: Tue, 25 Jun 2013 17:13:41 +0200
Subject: [PATCH] reverting changes to the markdown conversion pipeline order

---
 .../discourse/components/markdown.js          |  5 ++---
 test/javascripts/components/markdown_test.js  | 21 ++++++++++---------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/app/assets/javascripts/discourse/components/markdown.js b/app/assets/javascripts/discourse/components/markdown.js
index 51ade57eb6e..8f67853f53f 100644
--- a/app/assets/javascripts/discourse/components/markdown.js
+++ b/app/assets/javascripts/discourse/components/markdown.js
@@ -109,8 +109,7 @@ Discourse.Markdown = {
 
     // Extract quotes so their contents are not passed through markdown.
     converter.hooks.chain("preConversion", function(text) {
-      var formated = Discourse.BBCode.format(text, opts);
-      var extracted = Discourse.BBCode.extractQuotes(formated);
+      var extracted = Discourse.BBCode.extractQuotes(text);
       quoteTemplate = extracted.template;
       return extracted.text;
     });
@@ -185,7 +184,7 @@ Discourse.Markdown = {
         text = quoteTemplate(text);
       }
 
-      return text;
+      return Discourse.BBCode.format(text, opts);
     });
 
     if (opts.sanitize) {
diff --git a/test/javascripts/components/markdown_test.js b/test/javascripts/components/markdown_test.js
index 2903f95d2be..6ee020e73eb 100644
--- a/test/javascripts/components/markdown_test.js
+++ b/test/javascripts/components/markdown_test.js
@@ -68,16 +68,16 @@ test("Links", function() {
 test("Quotes", function() {
   cookedOptions("1[quote=\"bob, post:1\"]my quote[/quote]2",
                 { topicId: 2, lookupAvatar: function(name) { return "" + name; } },
-                "<p>1</p><aside class='quote' data-post=\"1\" > <br>\n  <div class='title'>\n    <div class='quote-controls'></div>\n" +
-                "  bob\n  bob\n  said:\n  </div>\n  <blockquote>my quote</blockquote>\n</aside> <br>\n<p>2</p>",
+                "<p>1</p><aside class='quote' data-post=\"1\" >\n  <div class='title'>\n    <div class='quote-controls'></div>\n" +
+                "  bob\n  bob\n  said:\n  </div>\n  <blockquote>my quote</blockquote>\n</aside>\n<p> <br>\n2</p>",
                 "handles quotes properly");
 
   cookedOptions("1[quote=\"bob, post:1\"]my quote[/quote]2",
                 { topicId: 2, lookupAvatar: function(name) { } },
-                "<p>1</p><aside class='quote' data-post=\"1\" > <br>\n  <div class='title'>\n    <div class='quote-controls'></div></p>\n" +
-                "\n<p>bob\n  said:\n  </div>\n  <blockquote>my quote</blockquote>\n</aside> <br>\n<p>2</p>",
+                "<p>1</p><aside class='quote' data-post=\"1\" >\n  <div class='title'>\n    <div class='quote-controls'></div>\n" +
+                "  \n  bob\n  said:\n  </div>\n  <blockquote>my quote</blockquote>\n</aside>\n<p> <br>\n2</p>",
                 "includes no avatar if none is found");
-});
+}); 
 
 test("Mentions", function() {
   cookedOptions("Hello @sam", { mentionLookup: (function() { return true; }) },
@@ -120,8 +120,9 @@ test("SanitizeHTML", function() {
 
 });
 
-test("with BBCode", function() {
-  cooked("[img]http://eviltrout.com/eviltrout.png[/img]",
-         "<p><img src=\"http://eviltrout.com/eviltrout.png\"></p>",
-         "BBCode is parsed first");
-});
+// TODO
+// test("with BBCode", function() {
+//   cooked("[img]http://eviltrout.com/eviltrout.png[/img]",
+//          "<p><img src=\"http://eviltrout.com/eviltrout.png\"></p>",
+//          "BBCode is parsed first");
+// });