IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: enable raise_error in test envs for deprecated icons in svg_sprite.rb (#30980)

Browse Source 
This PR raises an error on any deprecated icon names being converted by
svg_sprite.rb, which will result in any deprecated icons being processed
by the ruby lib to fail tests.
This commit is contained in:
Kelv
2025-02-04 21:21:20 +08:00
committed by GitHub
parent 8ad34862e4
commit 65324b6e5d
3 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/requests/svg_sprite_controller_spec.rb
View File

@@ -35,14 +35,14 @@ RSpec.describe SvgSpriteController do
describe "#search" do
it "should not work for anons" do
get "/svg-sprite/search/fa-bolt"
get "/svg-sprite/search/bolt"
expect(response.status).to eq(404)
end
it "should return symbol for FA icon search" do
sign_in(user)
get "/svg-sprite/search/fa-bolt"
get "/svg-sprite/search/bolt"
expect(response.status).to eq(200)
expect(response.body).to include("bolt")
end
@@ -50,7 +50,7 @@ RSpec.describe SvgSpriteController do
it "should return 404 when looking for non-existent FA icon" do
sign_in(user)
get "/svg-sprite/search/fa-not-a-valid-icon"
get "/svg-sprite/search/not-a-valid-icon"
expect(response.status).to eq(404)
end
@@ -72,7 +72,7 @@ RSpec.describe SvgSpriteController do
sign_in(user)
get "/svg-sprite/search/fa-my-custom-theme-icon"
get "/svg-sprite/search/my-custom-theme-icon"
expect(response.status).to eq(200)
expect(response.body).to include("my-custom-theme-icon")
end