IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove useless ordering when searching within a topic. (#14676)

Browse Source 
Searching within a topic currently does not make use of PG search and
we're simply doing an `ilike` against the post raw. Furthermore,
`Post#post_number` is already unique within a topic so the other
ordering will never ever be used. This change simply makes the query
cleaner to read.
This commit is contained in:
Alan Guo Xiang Tan 2021-10-22 10:38:21 +08:00 committed by GitHub
parent d1201d6188
commit 6544e3b02a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/search.rb
View File

@ -93,7 +93,6 @@ class Search
end
data = data.join(' ')
else
data.squish!
end
@ -990,7 +989,7 @@ class Search
.push(@search_context.id)
posts.where("topics.category_id in (?)", category_ids)
elsif @search_context.is_a?(Topic)
elsif is_topic_search
posts.where("topics.id = #{@search_context.id}")
.order("posts.post_number #{@order == :latest ? "DESC" : ""}")
elsif @search_context.is_a?(Tag)
@ -1028,7 +1027,7 @@ class Search
else
posts = posts.order("posts.like_count DESC")
end
else
elsif !is_topic_search
rank = <<~SQL
TS_RANK_CD(
post_search_data.search_data,