IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: ensures category chooser is case insensitive (#9850)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2020-05-21 11:16:44 +02:00 committed by GitHub
parent 7b6fbe9af2
commit 66960563ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/select-kit/addon/components/category-chooser.js
View File

@ -67,6 +67,7 @@ export default ComboBoxComponent.extend({
search(filter) { search(filter) {
if (filter) { if (filter) {
filter = filter.toLowerCase();
return this.content.filter(item => { return this.content.filter(item => {
const category = Category.findById(this.getValue(item)); const category = Category.findById(this.getValue(item));
const categoryName = this.getName(item); const categoryName = this.getName(item);

16
test/javascripts/acceptance/category-chooser-test.js
View File

@ -29,3 +29,19 @@ QUnit.test("prefill category when category_id is set", async assert => {
1 1
); );
}); });
QUnit.test("filter is case insensitive", async assert => {
const categoryChooser = selectKit(".category-chooser");
await visit("/");
await click("#create-topic");
await categoryChooser.expand();
await categoryChooser.fillInFilter("bug");
assert.ok(categoryChooser.rows().length, 1);
await categoryChooser.emptyFilter();
await categoryChooser.fillInFilter("Bug");
assert.ok(categoryChooser.rows().length, 1);
});

9
test/javascripts/helpers/select-kit-helper.js
View File

@ -32,6 +32,11 @@ async function selectKitFillInFilter(filter, selector) {
); );
} }
async function selectKitEmptyFilter(selector) {
checkSelectKitIsNotCollapsed(selector);
await fillIn(`${selector} .filter-input`, "");
}
async function selectKitSelectRowByValue(value, selector) { async function selectKitSelectRowByValue(value, selector) {
checkSelectKitIsNotCollapsed(selector); checkSelectKitIsNotCollapsed(selector);
await click(`${selector} .select-kit-row[data-value='${value}']`); await click(`${selector} .select-kit-row[data-value='${value}']`);
@ -180,6 +185,10 @@ export default function selectKit(selector) {
await selectKitFillInFilter(filter, selector); await selectKitFillInFilter(filter, selector);
}, },
async emptyFilter() {
await selectKitEmptyFilter(selector);
},
async keyboard(value, target) { async keyboard(value, target) {
await keyboardHelper(value, target, selector); await keyboardHelper(value, target, selector);
}, },