IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Return 404 if id is not valid.

Browse Source
This commit is contained in:
Guo Xiang Tan 2017-01-06 10:39:44 +08:00
parent d10fe51b72
commit 68300f515c
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/post_actions_controller.rb
View File

@ -6,6 +6,8 @@ class PostActionsController < ApplicationController
before_filter :fetch_post_action_type_id_from_params before_filter :fetch_post_action_type_id_from_params
def create def create
raise Discourse::NotFound if @post.blank?
taken = PostAction.counts_for([@post], current_user)[@post.id] taken = PostAction.counts_for([@post], current_user)[@post.id]
guardian.ensure_post_can_act!( guardian.ensure_post_can_act!(

5
spec/controllers/post_actions_controller_spec.rb
View File

@ -31,6 +31,11 @@ describe PostActionsController do
expect { xhr :post, :create, post_action_type_id: PostActionType.types[:like] }.to raise_error(ActionController::ParameterMissing) expect { xhr :post, :create, post_action_type_id: PostActionType.types[:like] }.to raise_error(ActionController::ParameterMissing)
end end
it 'fails when the id is invalid' do
xhr :post, :create, post_action_type_id: PostActionType.types[:like], id: -1
expect(response.status).to eq(404)
end
it 'raises an error when the post_action_type_id index is missing' do it 'raises an error when the post_action_type_id index is missing' do
expect { xhr :post, :create, id: @post.id }.to raise_error(ActionController::ParameterMissing) expect { xhr :post, :create, id: @post.id }.to raise_error(ActionController::ParameterMissing)
end end