FIX: invalid urls should not break store.has_been_uploaded?

Breaking this method has wide ramification including breaking
search indexing.
This commit is contained in:
Sam Saffron
2020-06-25 15:00:15 +10:00
parent 88459e08c9
commit 689568c216
2 changed files with 8 additions and 4 deletions

View File

@@ -89,7 +89,10 @@ module FileStore
begin
parsed_url = URI.parse(UrlHelper.encode(url))
rescue URI::InvalidURIError, URI::InvalidComponentError
rescue
# There are many exceptions possible here including Addressable::URI:: excpetions
# and URI:: exceptions, catch all may seem wide, but it makes no sense to raise ever
# on an invalid url here
return false
end